Attachment 59340 Details for Bug 17909 – Bug 17909: QA followup: remove unused var and move global var

[patch] Bug 17909: QA followup: remove unused var and move global var

Bug-17909-QA-followup-remove-unused-var-and-move-g.patch (text/plain), 1.28 KB, created by Julian Maurice on 2017-01-20 11:25:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2017-01-20 11:25:25 UTC

Size: 1.28 KB

patch

obsolete

>From afc26501fa79014db7ec1127cb64ca0087cbce70 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 20 Jan 2017 12:16:44 +0100
>Subject: [PATCH] Bug 17909: QA followup: remove unused var and move global var
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> t/db_dependent/Authorities/Merge.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Authorities/Merge.t b/t/db_dependent/Authorities/Merge.t
>index 17656b1f95..50e4520859 100755
>--- a/t/db_dependent/Authorities/Merge.t
>+++ b/t/db_dependent/Authorities/Merge.t
>@@ -22,11 +22,9 @@ BEGIN {
> my $schema  = Koha::Database->new->schema;
> $schema->storage->txn_begin;
> my $dbh = C4::Context->dbh;
>-my $builder = t::lib::TestBuilder->new;
> 
> # Some advanced mocking :)
> my ( @zebrarecords, $index );
>-my $auth_mod = Test::MockModule->new( 'C4::AuthoritiesMarc' );
> my $context_mod = Test::MockModule->new( 'C4::Context' );
> my $search_mod = Test::MockModule->new( 'C4::Search' );
> my $zoom_mod = Test::MockModule->new( 'ZOOM::Query::CCL2RPN', no_auto => 1 );
>@@ -205,6 +203,8 @@ sub set_mocks {
> }
> 
> sub modify_framework {
>+    my $builder = t::lib::TestBuilder->new;
>+
>     # create two auth types
>     my $authtype1 = $builder->build({
>         source => 'AuthType',
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 17909: 59005 | 59006 | 59007 | 59008 | 59011 | 59012 | 59013 | 59014 | 59015 | 59077 | 59088 | 59323 | 59324 | 59334 | 59335 | 59336 | 59337 | 59338 | 59339 | 59340