Bugzilla – Attachment 59710 Details for
Bug 17855
New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17855 - Implemented a retrieval of patron category enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron accounts created with the onboarding tool.
Bug-17855---Implemented-a-retrieval-of-patron-cate.patch (text/plain), 3.17 KB, created by
Mark Tompsett
on 2017-02-01 02:02:51 UTC
(
hide
)
Description:
Bug 17855 - Implemented a retrieval of patron category enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron accounts created with the onboarding tool.
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-02-01 02:02:51 UTC
Size:
3.17 KB
patch
obsolete
>From 378aa4fad6974ba13f1af880e3cd0d635141a56e Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Fri, 27 Jan 2017 18:17:41 +0000 >Subject: [PATCH] Bug 17855 - Implemented a retrieval of patron category > enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for > patron accounts created with the onboarding tool. > >Set address and city variables to "" in onboarding.pl > >Fixed the creation/filling of the $firstpassword, $secondpassword and >$op variables in the onboarding.pl so they don't cause uninitialised >variable errors. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > installer/onboarding.pl | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > >diff --git a/installer/onboarding.pl b/installer/onboarding.pl >index d7c2f75..1239ac8 100755 >--- a/installer/onboarding.pl >+++ b/installer/onboarding.pl >@@ -45,6 +45,7 @@ use Koha::LibraryCategories; > use Koha::Database; > use Koha::DateUtils; > use Koha::Patron::Categories; >+use Koha::Patron::Category; > use Koha::Patron::HouseboundRole; > use Koha::Patron::HouseboundRoles; > use Koha::Token; >@@ -91,7 +92,7 @@ my $dbh = DBI->connect( > ); > > #Store the value of the template input name='op' in the variable $op so we can check if the user has pressed the button with the name="op" and value="finish" meaning the user has finished the onboarding tool. >-my $op = $input->param('op'); >+my $op = $input->param('op') || ""; > $template->param( 'op' => $op ); > > if ( $op && $op eq 'finish' ) >@@ -241,8 +242,8 @@ elsif ( $step && $step == 2 ) { > #Create a patron > } > elsif ( $step && $step == 3 ) { >- my $firstpassword = $input->param('password'); >- my $secondpassword = $input->param('password2'); >+ my $firstpassword = $input->param('password') || ""; >+ my $secondpassword = $input->param('password2') || ""; > > > #Find all patron records in the database and hand them to the template >@@ -280,6 +281,9 @@ elsif ( $step && $step == 3 ) { > my $categories = Koha::Patron::Categories->search(); > $template->param( 'categories' => $categories, ); > >+ >+ >+ > #Incrementing the highest existing patron cardnumber to prevent duplicate cardnumber entry > my $exisiting_cardnumber = my $sth_search = > $dbh->prepare("SELECT MAX(cardnumber) FROM borrowers"); >@@ -378,8 +382,13 @@ elsif ( $step && $step == 3 ) { > $newdata{userid} = $input->param('userid'); > $newdata{password} = $input->param('password'); > $newdata{password2} = $input->param('password2'); >- $newdata{dateexpiry} = '12/10/2016'; > $newdata{privacy} = "default"; >+ $newdata{address} = ""; >+ $newdata{city} = ""; >+ >+#Determine the dateexpiry of the patron based on the patron category it is created from >+ my $patron_category = Koha::Patron::Categories->find( $newdata{categorycode} ); >+ $newdata{dateexpiry} = $patron_category->get_expiry_date( $newdata{dateenrolled} ); > > #Hand the newdata hash to the AddMember subroutine in the C4::Members module and it creates a patron and hands back a borrowernumber which is being stored > my $borrowernumber = &AddMember(%newdata); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17855
:
58657
|
58658
|
58659
|
58660
|
58661
|
58662
|
58663
|
58664
|
58665
|
58666
|
58667
|
58668
|
58669
|
58781
|
58782
|
58783
|
58784
|
58785
|
58792
|
58793
|
58794
|
58846
|
58860
|
58861
|
58862
|
58886
|
58892
|
58893
|
58894
|
58895
|
58896
|
58897
|
58898
|
58899
|
58900
|
58901
|
58902
|
58903
|
58904
|
58905
|
58906
|
58907
|
59037
|
59051
|
59140
|
59141
|
59174
|
59188
|
59277
|
59279
|
59280
|
59281
|
59628
|
59703
|
59705
|
59706
|
59707
|
59708
|
59709
|
59710
|
59711
|
59712
|
59742
|
59826
|
59830
|
59840
|
59841
|
59842
|
59856
|
59857
|
60092
|
61667
|
61668
|
61986
|
62186
|
62191
|
62192
|
62193
|
62220
|
62221
|
62222
|
62223
|
62231
|
62233
|
62234
|
62235
|
62236
|
62237
|
62238
|
62239
|
62240
|
62241
|
62242
|
62243
|
62251
|
62252
|
62253
|
62254
|
62255
|
62256
|
62257
|
62258
|
62259
|
62260
|
62261
|
62262
|
62263
|
62281
|
62282
|
62283
|
62284
|
62285
|
62286
|
62287
|
62288
|
62668
|
62669
|
62670
|
62671
|
62672
|
62673
|
62674
|
62675