Bugzilla – Attachment 61340 Details for
Bug 18010
Remove potential exposure from gettemplate
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18010: Unit test for gettemplate
Bug-18010-Unit-test-for-gettemplate.patch (text/plain), 1.43 KB, created by
Chris Cormack
on 2017-03-20 19:48:04 UTC
(
hide
)
Description:
Bug 18010: Unit test for gettemplate
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2017-03-20 19:48:04 UTC
Size:
1.43 KB
patch
obsolete
>From 837cd69fce2a2a35b6f55f1d64cd2253c074130e Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Sun, 29 Jan 2017 15:52:22 +0100 >Subject: [PATCH] Bug 18010: Unit test for gettemplate > >A trivial test, similar to the ones in Auth.t. >Without the check in gettemplate (added in the second patch), the passwd >file will be exposed and the test fails. > >Test plan: >Run t/db_dependent/Templates.t without second patch. The two tests in the >last subtest should fail. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > t/db_dependent/Templates.t | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Templates.t b/t/db_dependent/Templates.t >index 35fd738ced..2df099ebbc 100755 >--- a/t/db_dependent/Templates.t >+++ b/t/db_dependent/Templates.t >@@ -19,9 +19,10 @@ use Modern::Perl; > > use CGI; > >-use Test::More tests => 6; >+use Test::More tests => 7; > use Test::Deep; > use Test::MockModule; >+use Test::Warn; > > use t::lib::Mocks; > >@@ -96,4 +97,12 @@ subtest 'Testing themelanguage' => sub { > return; > }; > >+subtest 'Testing gettemplate' => sub { >+ plan tests => 2; >+ >+ my $template; >+ warning_like { eval { $template = C4::Templates::gettemplate( '/etc/passwd', 'opac', CGI->new, 1 ) }; warn $@ if $@; } qr/bad template/, 'Bad template check'; >+ is( $template ? $template->output: '', '', 'Check output' ); >+}; >+ > 1; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18010
:
59631
|
59632
|
60418
|
60419
|
61340
|
61341
|
61344
|
61345