Bugzilla – Attachment 64454 Details for
Bug 18651
Move of checkouts is still not correctly handled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18651: [QA Follow-up] Remove unused variable
Bug-18651-QA-Follow-up-Remove-unused-variable.patch (text/plain), 1017 bytes, created by
Marcel de Rooy
on 2017-06-20 13:15:51 UTC
(
hide
)
Description:
Bug 18651: [QA Follow-up] Remove unused variable
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-06-20 13:15:51 UTC
Size:
1017 bytes
patch
obsolete
>From 27bbb4fb8e9dd2ef9c406a2bcb4f81c4e2834bd4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 20 Jun 2017 14:19:12 +0200 >Subject: [PATCH] Bug 18651: [QA Follow-up] Remove unused variable >Content-Type: text/plain; charset=utf-8 > >Variable $original_issue_id is not used. The id is retrieved later from >$issue when updating accountlines. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Circulation.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index c89624e..07f1887 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2180,7 +2180,6 @@ sub MarkIssueReturned { > C4::Context->dbh->do(q|LOCK TABLE old_issues READ|) unless $do_not_lock; > C4::Context->dbh->do(q|LOCK TABLE old_issues WRITE|) unless $do_not_lock; > >- my $original_issue_id = $issue_id; > my $issue = Koha::Checkouts->find( $issue_id ); # FIXME should be fetched earlier > > # Create the old_issues entry >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18651
:
63629
|
63630
|
63631
|
63632
|
63633
|
63634
|
63635
|
63636
|
63637
|
63654
|
63659
|
63706
|
64352
|
64353
|
64354
|
64355
|
64356
|
64357
|
64394
|
64395
|
64396
|
64397
|
64398
|
64399
|
64448
|
64449
|
64450
|
64451
|
64452
|
64453
| 64454 |
64455
|
64489
|
64490
|
64495
|
65134