Bugzilla – Attachment 64600 Details for
Bug 18465
Patron card creator: Print on duplex card printer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18465: (followup) Fix issue with patron lists an ddo notuse clone
Bug-18465-followup-Fix-issue-with-patron-lists-an-.patch (text/plain), 2.55 KB, created by
Marc Véron
on 2017-06-23 17:48:44 UTC
(
hide
)
Description:
Bug 18465: (followup) Fix issue with patron lists an ddo notuse clone
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-06-23 17:48:44 UTC
Size:
2.55 KB
patch
obsolete
>From 00ac6f9a51c90dd9d700c47cf1676f07ed47cd09 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Fri, 23 Jun 2017 18:48:00 +0200 >Subject: [PATCH] Bug 18465: (followup) Fix issue with patron lists an ddo > notuse clone > >This followup fixes duplex printing with patron lists. > >Additionaly, it uses simple copy instead of clone and removes a >superfluous line, see comments #15 - #17 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt | 2 +- > patroncards/create-pdf.pl | 5 +---- > 2 files changed, 2 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt >index 950cf4e..f2ab3c6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt >@@ -49,7 +49,7 @@ > [% ELSIF ( patronlist_id && template_id && layout_id ) %] > <h3>Click on the link to download the patron cards from the patron list.</h3> > <p> >- <a class="document pdf" href="/cgi-bin/koha/patroncards/create-pdf.pl?patronlist_id=[% patronlist_id %]&template_id=[% template_id %]&layout_id=[% layout_id %]&start_card=[% start_card %]">label_patronlist_[% patronlist_id %].pdf</a> >+ <a class="document pdf" href="/cgi-bin/koha/patroncards/create-pdf.pl?patronlist_id=[% patronlist_id %]&template_id=[% template_id %]&layout_id=[% layout_id %]&layout_back_id=[% layout_back_id %]&start_card=[% start_card %]">label_patronlist_[% patronlist_id %].pdf</a> > </p> > [% ELSE %] > <h3> >diff --git a/patroncards/create-pdf.pl b/patroncards/create-pdf.pl >index 9f21a50..05cfcbd 100755 >--- a/patroncards/create-pdf.pl >+++ b/patroncards/create-pdf.pl >@@ -26,7 +26,6 @@ use Graphics::Magick; > use XML::Simple; > use POSIX qw(ceil); > use autouse 'Data::Dumper' => qw(Dumper); >-use Clone qw(clone); > > use C4::Debug; > use C4::Context; >@@ -131,10 +130,8 @@ if ($layout_xml->{'page_side'} eq 'B') { # rearrange items on backside of page t > CARD_ITEMS: > foreach my $item (@{$items}) { > if ($item) { >- >-#my $print_layout_xml = $layout_back_xml; > my $print_layout_xml = (( ($cardscount % 2 == 1) && ( $layout_back_id ) ) ? >- clone($layout_back_xml) : clone($layout_xml) ); >+ $layout_back_xml : $layout_xml ); > > $cardscount ++; > my $borrower_number = $item->{'borrower_number'}; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18465
:
62498
|
63011
|
63012
|
63046
|
64599
|
64600
|
64601
|
64606
|
64607