Bugzilla – Attachment 64785 Details for
Bug 18228
Make list permissions easier to use/understand
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
QA Followup - use gender neutral language in new tests
QA-Followup---use-gender-neutral-language-in-new-t.patch (text/plain), 2.87 KB, created by
Nick Clemens (kidclamp)
on 2017-07-03 17:03:01 UTC
(
hide
)
Description:
QA Followup - use gender neutral language in new tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-07-03 17:03:01 UTC
Size:
2.87 KB
patch
obsolete
>From 02c6c51f40df12771405b41faafca43442409db4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 3 Jul 2017 17:01:02 +0000 >Subject: [PATCH] QA Followup - use gender neutral language in new tests > >https://bugs.koha-community.org/show_bug.cgi?id=18228 >--- > t/db_dependent/Virtualshelves.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Virtualshelves.t b/t/db_dependent/Virtualshelves.t >index b092ae8..2bbf00e 100644 >--- a/t/db_dependent/Virtualshelves.t >+++ b/t/db_dependent/Virtualshelves.t >@@ -262,10 +262,10 @@ subtest 'Shelf permissions' => sub { > is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); > is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by someone else' ); > >- is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to his list' ); >+ is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to their list' ); > is( $public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone else' ); > >- is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to his list' ); >+ is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to their list' ); > is( $public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (remove) by someone else' ); > > >@@ -306,10 +306,10 @@ subtest 'Shelf permissions' => sub { > is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); > is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by someone else' ); > >- is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to his list' ); >+ is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to their list' ); > is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Private list should not be modified (add) by someone else' ); > >- is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to his list' ); >+ is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to their list' ); > is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Private list should not be modified (remove) by someone else' ); > > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18228
:
60939
|
60940
|
60941
|
60942
|
60943
|
61471
|
61475
|
61476
|
61477
|
61478
|
63474
|
64505
|
64506
|
64507
|
64508
|
64509
|
64780
|
64781
|
64782
|
64783
|
64784
| 64785