Bugzilla – Attachment 74620 Details for
Bug 20100
A non-superlibrarian should not be able to add superlibrarian privileges
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20100: Disallow access to superlibrarian privileges at client side
Bug-20100-Disallow-access-to-superlibrarian-privil.patch (text/plain), 1.66 KB, created by
Nick Clemens (kidclamp)
on 2018-04-20 11:54:46 UTC
(
hide
)
Description:
Bug 20100: Disallow access to superlibrarian privileges at client side
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-04-20 11:54:46 UTC
Size:
1.66 KB
patch
obsolete
>From babf8e12533023359ab8c1621c4d71c37a5c9d53 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 31 Jan 2018 16:47:23 +0100 >Subject: [PATCH] Bug 20100: Disallow access to superlibrarian privileges at > client side > >This last patch activates the check at client side. >If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be >able to change superlibrarian privileges via the interface. > >Test plan: >[1] Enable the pref. >[2] Login as superlib and add/remove superlib privs to a staff user. >[3] Login as another user (no superlib, but having borrowers, permissions > and staff_access). Verify that you cannot add or remove superlib > privs. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt >index d380187..f5631f2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt >@@ -122,6 +122,12 @@ > } > }); > >+ [% IF disable_superlibrarian_privs %] >+ $("input#flag-0").attr("disabled", true); >+ $("form").submit(function(e) { >+ $("input#flag-0").removeAttr("disabled"); >+ }); >+ [% END %] > }); > > // manage checking/unchecking parent permissions >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20100
:
71091
|
71092
|
71093
|
71918
|
72260
|
72261
|
72262
|
72747
|
72749
|
72750
|
74618
|
74619
| 74620 |
74621
|
74721
|
74840
|
74841
|
74844
|
74846