Bugzilla – Attachment 75678 Details for
Bug 17561
ReserveSlip needs itemnumber for item level holds on same biblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17561: (follow-up) Pass itemnumber on returns and correct itemnumber param in circulation
Bug-17561-follow-up-Pass-itemnumber-on-returns-and.patch (text/plain), 4.15 KB, created by
Jonathan Druart
on 2018-05-30 16:16:05 UTC
(
hide
)
Description:
Bug 17561: (follow-up) Pass itemnumber on returns and correct itemnumber param in circulation
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-05-30 16:16:05 UTC
Size:
4.15 KB
patch
obsolete
>From 97fc55926fbb14ddda27b36c4d86dea68ffe96eb Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 30 May 2018 13:07:39 +0000 >Subject: [PATCH] Bug 17561: (follow-up) Pass itemnumber on returns and correct > itemnumber param in circulation > >To test: >1 - Place two holds on a bib for a single patron >2 - Check in both items, confirm the screen message and slip are correct >3 - Checkout both items to another patron, confirm the screen message >and slip are correct > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > circ/returns.pl | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 1e09336ac1..a82bdc1432 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -80,6 +80,7 @@ if ( $query->param('print_slip') ) { > print_slip => 1, > borrowernumber => scalar $query->param('borrowernumber'), # FIXME We should send a Koha::Patron and raise an error if not exist. > biblionumber => scalar $query->param('biblionumber'), >+ itemnumber => scalar $query->param('itemnumber'), > ); > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index d4955394e0..a6e6ba00fa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -257,7 +257,7 @@ > <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber %]" /> > <input type="hidden" name="duedatespec" value="[% duedatespec %]" /> > <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" /> >- <button class="print" type="submit" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% reserveborrowernumber %]&biblionumber=[% itembiblionumber %]&itemnumber=[% itemnumber %]&op=slip');this.form.submit();"><i class="fa fa-print"></i> Don't check out and print slip (P)</button> >+ <button class="print" type="submit" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% reserveborrowernumber %]&biblionumber=[% itembiblionumber %]&itemnumber=[% item.itemnumber %]&op=slip');this.form.submit();"><i class="fa fa-print"></i> Don't check out and print slip (P)</button> > </form> > [% END %] > >@@ -267,7 +267,7 @@ > <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber %]" /> > <input type="hidden" name="duedatespec" value="[% duedatespec %]" /> > <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" /> >- <button class="print" type="submit" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% reserveborrowernumber %]&biblionumber=[% itembiblionumber %]&itemnumber=[% itemnumber %]&op=slip');this.form.submit();"><i class="fa fa-print"></i> Don't check out and print slip (P)</button> >+ <button class="print" type="submit" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% reserveborrowernumber %]&biblionumber=[% itembiblionumber %]&itemnumber=[% item.itemnumber %]&op=slip');this.form.submit();"><i class="fa fa-print"></i> Don't check out and print slip (P)</button> > </form> > [% END %] > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 119116fa07..051d66ac64 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -709,7 +709,7 @@ > $(".modal").on('hidden.bs.modal', function (e) { $("#barcode").focus(); }); > > [% IF print_slip %] >- Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&biblionumber=[% biblionumber %]'); >+ Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&biblionumber=[% biblionumber %]&itemnumber=[% itemnumber %]'); > [% END %] > > var columns_settings = [% ColumnsSettings.GetColumns( 'circ', 'returns', 'checkedintable', 'json' ) %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17561
:
57239
|
57293
|
72678
|
72939
|
72967
|
73064
|
75421
|
75422
|
75423
|
75424
|
75425
|
75426
|
75659
|
75675
|
75676
|
75677
| 75678