Attachment 76963 Details for Bug 21064 – Bug 21064: Use undefined instead of undef

[patch] Bug 21064: Use undefined instead of undef

Bug-21064-Use-undefined-instead-of-undef.patch (text/plain), 1.18 KB, created by Pierre-Luc Lapointe on 2018-07-13 19:28:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pierre-Luc Lapointe

Created: 2018-07-13 19:28:20 UTC

Size: 1.18 KB

patch

obsolete

>From b4e1b58241d9a0611ce2eb36661645d7cac11546 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 12 Jul 2018 10:18:10 +0000
>Subject: [PATCH] Bug 21064: Use undefined instead of undef
>
>To test:
>1 - Load the advanced cataloging editor
>2 - Refresh the page several times
>3 - Check the JS console, you shoudl see an error:
>    'undef is not defined'
>4 - Apply patch
>5 - Try again, should be no error
>
>Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>index 68a168f..61d080e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>@@ -1089,7 +1089,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr
>             if(editor.modified )
>                 { return 1; }
>             else
>-                { return undef; }
>+                { return undefined; }
>         };
> 
>         // Start editor
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 21064: 76882 | 76963 | 77065