Bugzilla – Attachment 81126 Details for
Bug 21658
Renew requests fail if a fee attached
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch to stop sipserver crash handling fees
0001-Bug-21658-Explicitly-call-getnextacctno.patch (text/plain), 1.50 KB, created by
Colin Campbell
on 2018-10-25 10:18:24 UTC
(
hide
)
Description:
patch to stop sipserver crash handling fees
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2018-10-25 10:18:24 UTC
Size:
1.50 KB
patch
obsolete
>From f40961c2a9dec4bb1b1f546b1fe863d5bb99b165 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 25 Oct 2018 09:52:36 +0100 >Subject: [PATCH 1/3] Bug 21658 Explicitly call getnextacctno > >Sipserver was crashing if required to apply a rental fee >problem was a run time error because it was resolving >the symbol getnextacctno as C4::Circulation::getnextacctno >a nonexistant subroutine >This fixes it in the crude way of calling the version in >Accounts explicitly >--- > C4/Circulation.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 9c8d5ba13e..10f8104352 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2851,7 +2851,7 @@ sub AddRenewal { > # Charge a new rental fee, if applicable? > my ( $charge, $type ) = GetIssuingCharges( $itemnumber, $borrowernumber ); > if ( $charge > 0 ) { >- my $accountno = getnextacctno( $borrowernumber ); >+ my $accountno =C4::Accounts::getnextacctno( $borrowernumber ); > my $manager_id = 0; > $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv; > $sth = $dbh->prepare( >@@ -3191,7 +3191,7 @@ sub AddIssuingCharge { > > # FIXME What if checkout does not exist? > >- my $nextaccntno = getnextacctno($checkout->borrowernumber); >+ my $nextaccntno = C4::Accounts::getnextacctno($checkout->borrowernumber); > > my $manager_id = 0; > $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv; >-- >2.17.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21658
: 81126 |
81127
|
81128
|
89487
|
89488