Bugzilla – Attachment 8319 Details for
Bug 7724
Tests requiring Zebra should be skipped if Zebra isn't set up
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 7724: Skip Linker test if Zebra isn't set up
PASSED-QA-Bug-7724-Skip-Linker-test-if-Zebra-isnt-.patch (text/plain), 1.37 KB, created by
Ian Walls
on 2012-03-20 00:22:18 UTC
(
hide
)
Description:
[PASSED QA] Bug 7724: Skip Linker test if Zebra isn't set up
Filename:
MIME Type:
Creator:
Ian Walls
Created:
2012-03-20 00:22:18 UTC
Size:
1.37 KB
patch
obsolete
>From e99d1537f09a5e04f0f022110bceca50e45d4850 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Fri, 16 Mar 2012 07:38:24 -0400 >Subject: [PATCH] [PASSED QA] Bug 7724: Skip Linker test if Zebra isn't set up > >One of the tests in t/db_dependent/Linker_FirstMatch.t ony works if Zebra is >running and authorities have been indexed. This was causing Jenkins agitas. >The test should be skipped if Zebra isn't running or authorities have not been >indexed at the time the test is run. > >Signed-off-by: Ian Walls <koha.sekjal@gmail.com> >--- > t/db_dependent/Linker_FirstMatch.t | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > >diff --git a/t/db_dependent/Linker_FirstMatch.t b/t/db_dependent/Linker_FirstMatch.t >index a2d3c60..66c03ba 100755 >--- a/t/db_dependent/Linker_FirstMatch.t >+++ b/t/db_dependent/Linker_FirstMatch.t >@@ -39,6 +39,12 @@ SKIP: { > my $heading; > ok(defined ($heading = C4::Heading->new_from_bib_field($bibfield, '')), "Creating heading from bib field"); > >+ # If Zebra is not running, or authorities have not been indexed, test 3 >+ # will fail. Skip it if we are unable to retrieve a list of headings from >+ # Zebra. >+ my @authids = $heading->authorities(1); >+ skip "Unable to search Zebra", 1 unless $#authids > 0; >+ > my $authmatch; > my $fuzzy; > ($authmatch, $fuzzy) = $linker->get_link($heading); >-- >1.7.0.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7724
:
8221
| 8319