Attachment 86564 Details for Bug 10577 – Bug 10577: (QA follow-up) Remove bad call signature

[patch] Bug 10577: (QA follow-up) Remove bad call signature

Bug-10577-QA-follow-up-Remove-bad-call-signature.patch (text/plain), 1.08 KB, created by Martin Renvoize (ashimema) on 2019-03-13 11:17:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-03-13 11:17:48 UTC

Size: 1.08 KB

patch

obsolete

>From 841cf970be6914165f3c4b119191d8b73e69e00b Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 13 Mar 2019 11:16:09 +0000
>Subject: [PATCH] Bug 10577: (QA follow-up) Remove bad call signature
>
>Whilst working through this patch for signoff I found a case where the
>calling signature of GetBudgetPeriod was incorrect. I removed the
>superflous passed parameter in this followup
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> admin/aqbudgetperiods.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/aqbudgetperiods.pl b/admin/aqbudgetperiods.pl
>index 0a05a5539b..aa2998d91a 100755
>--- a/admin/aqbudgetperiods.pl
>+++ b/admin/aqbudgetperiods.pl
>@@ -159,7 +159,7 @@ elsif ( $op eq 'delete_confirmed' ) {
> 
> # display the form for duplicating
> elsif ( $op eq 'duplicate_form'){
>-    my $budgetperiod = GetBudgetPeriod($budget_period_id, $input);
>+    my $budgetperiod = GetBudgetPeriod($budget_period_id);
>     $template->param(
>         'duplicate_form' => '1',
>         'budget_period_id' => $budget_period_id,
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 10577: 19578 | 86563 | 86564 | 86565 | 86566 | 87009 | 87010 | 87080 | 87081 | 87082