Attachment 91613 Details for Bug 21316 – Bug 21316: Handle control fields in the ACQ frameworks

[patch] Bug 21316: Handle control fields in the ACQ frameworks

Bug-21316-Handle-control-fields-in-the-ACQ-framewo.patch (text/plain), 1.64 KB, created by Marcel de Rooy on 2019-07-19 06:47:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-07-19 06:47:35 UTC

Size: 1.64 KB

patch

obsolete

>From 9962c13bd9f4d7f7d82e405bddbe6a8c9cbbaf8d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 5 Mar 2019 16:09:07 -0300
>Subject: [PATCH] Bug 21316: Handle control fields in the ACQ frameworks
>MIME-Version: 1.0
>Content-Type: text/plain; charset=utf-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>- Turn UseACQFrameworkForBiblioRecords on
>- Add 003@ to the ACQ framework
>- Create an order from an existing record
>=> The 003 value will be displayed!
>
>It fixes the following error:
>Control fields (generally, just tags below 010) do not have subfields,
>use data() at /home/vagrant/kohaclone/acqui/neworderempty.pl line 293.
>
>Signed-off-by: Christian StelzenmÃ¼ller <christian.stelzenmueller@bsz-bw.de>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> acqui/neworderempty.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl
>index 86e7339194..fb1b66a53e 100755
>--- a/acqui/neworderempty.pl
>+++ b/acqui/neworderempty.pl
>@@ -290,7 +290,7 @@ if ( not $ordernumber or $biblionumber ) {
>                 next if IsMarcStructureInternal($mss);
>                 next if $mss->{tab} == -1;
>                 # We only need to display the values
>-                my $value = join '; ', map { $_->subfield( $subfield ) } @fields;
>+                my $value = join '; ', map { $tag < 10 ? $_->data : $_->subfield( $subfield ) } @fields;
>                 if ( $value ) {
>                     push @catalog_details, {
>                         tag => $tag,
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21316: 86114 | 91484 | 91516 | 91613