Attachment 93353 Details for Bug 20589 – Bug 20589: Remove expanded_facet variable and fix tests

[patch] Bug 20589: Remove expanded_facet variable and fix tests

Bug-20589-Remove-expandedfacet-variable-and-fix-te.patch (text/plain), 1.70 KB, created by Nick Clemens (kidclamp) on 2019-10-01 09:25:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-10-01 09:25:20 UTC

Size: 1.70 KB

patch

obsolete

>From 1b6096d75283e63c9f58cd13689ea27220d587a7 Mon Sep 17 00:00:00 2001
>From: Nick <nick@bywatersolutions.com>
>Date: Tue, 1 Oct 2019 09:02:20 +0000
>Subject: [PATCH] Bug 20589: Remove expanded_facet variable and fix tests
>
>Thi is a rebase from 14419 to remove an unused variable
>
>Also update tests to expect the new expected result
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> opac/opac-search.pl                                           | 1 -
> t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index 582ce565b5..ea78ca0b23 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -565,7 +565,6 @@ if (C4::Context->preference('OpacSuppression')) {
>     0,
>     $lang,
>     {
>-        expanded_facet => $expanded_facet,
>         suppress => $suppress,
>         is_opac => 1,
>         weighted_fields => !$cgi->param('advsearch')
>diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>index 488e4ac80c..5e695a0738 100644
>--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>@@ -178,7 +178,7 @@ subtest 'build_authorities_query_compat() tests' => sub {
>     $query = $qb->build_authorities_query_compat( [ 'mainentry' ],  undef, undef, ['contains'], [$search_term], 'AUTH_TYPE', 'asc' );
>     is_deeply(
>         $query->{query}->{bool}->{filter},
>-        { term => { 'authtype' => 'auth_type' } },
>+        { term => { 'authtype.raw' => 'AUTH_TYPE' } },
>         "authorities type code is used as filter"
>     );
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20589: 74245 | 74249 | 74301 | 74373 | 74418 | 74419 | 82503 | 82544 | 83016 | 83019 | 87358 | 87411 | 87412 | 87415 | 87416 | 92454 | 92455 | 92456 | 92457 | 93238 | 93239 | 93240 | 93241 | 93247 | 93248 | 93249 | 93250 | 93251 | 93348 | 93349 | 93350 | 93351 | 93352 | 93353 | 93379 | 93380 | 93381 | 93382 | 93383 | 93384 | 93590 | 93624