Bugzilla – Attachment 93384 Details for
Bug 20589
Add field boosting and use elastic query fields parameter instead of deprecated _all
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20589: Remove expanded_facet variable and fix tests
Bug-20589-Remove-expandedfacet-variable-and-fix-te.patch (text/plain), 1.74 KB, created by
Alex Arnaud
on 2019-10-01 15:04:15 UTC
(
hide
)
Description:
Bug 20589: Remove expanded_facet variable and fix tests
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2019-10-01 15:04:15 UTC
Size:
1.74 KB
patch
obsolete
>From e0887e6d1cdf25ce48f0b5621e8944497bd80d21 Mon Sep 17 00:00:00 2001 >From: Nick <nick@bywatersolutions.com> >Date: Tue, 1 Oct 2019 09:02:20 +0000 >Subject: [PATCH] Bug 20589: Remove expanded_facet variable and fix tests > >Thi is a rebase from 14419 to remove an unused variable > >Also update tests to expect the new expected result > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> >--- > opac/opac-search.pl | 1 - > t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index 582ce56..ea78ca0 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -565,7 +565,6 @@ if (C4::Context->preference('OpacSuppression')) { > 0, > $lang, > { >- expanded_facet => $expanded_facet, > suppress => $suppress, > is_opac => 1, > weighted_fields => !$cgi->param('advsearch') >diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >index 488e4ac..5e695a0 100644 >--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >@@ -178,7 +178,7 @@ subtest 'build_authorities_query_compat() tests' => sub { > $query = $qb->build_authorities_query_compat( [ 'mainentry' ], undef, undef, ['contains'], [$search_term], 'AUTH_TYPE', 'asc' ); > is_deeply( > $query->{query}->{bool}->{filter}, >- { term => { 'authtype' => 'auth_type' } }, >+ { term => { 'authtype.raw' => 'AUTH_TYPE' } }, > "authorities type code is used as filter" > ); > >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20589
:
74245
|
74249
|
74301
|
74373
|
74418
|
74419
|
82503
|
82544
|
83016
|
83019
|
87358
|
87411
|
87412
|
87415
|
87416
|
92454
|
92455
|
92456
|
92457
|
93238
|
93239
|
93240
|
93241
|
93247
|
93248
|
93249
|
93250
|
93251
|
93348
|
93349
|
93350
|
93351
|
93352
|
93353
|
93379
|
93380
|
93381
|
93382
|
93383
| 93384 |
93590
|
93624