Bugzilla – Attachment 99879 Details for
Bug 20728
Remove subroutines GetLastOrder*
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20728: Remove the 2 GetLastOrder* subroutines
Bug-20728-Remove-the-2-GetLastOrder-subroutines.patch (text/plain), 2.54 KB, created by
Jonathan Druart
on 2020-03-02 10:46:08 UTC
(
hide
)
Description:
Bug 20728: Remove the 2 GetLastOrder* subroutines
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-03-02 10:46:08 UTC
Size:
2.54 KB
patch
obsolete
>From cdba13406befb2cb94af448bebaa7da0d01511ca Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 15 Mar 2019 19:38:29 -0300 >Subject: [PATCH] Bug 20728: Remove the 2 GetLastOrder* subroutines > >At this point the 2 subroutines are no longer in used. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Acquisition.pm | 52 ----------------------------------------------- > 1 file changed, 52 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index e60cec2353..1603e6d6ef 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -70,7 +70,6 @@ BEGIN { > &SearchOrders &GetHistory &GetRecentAcqui > &ModReceiveOrder &CancelReceipt > &TransferOrder >- &GetLastOrderNotReceivedFromSubscriptionid &GetLastOrderReceivedFromSubscriptionid > &ModItemOrder > > &GetParcels >@@ -1247,57 +1246,6 @@ sub GetOrder { > return $result_set->[0]; > } > >-=head3 GetLastOrderNotReceivedFromSubscriptionid >- >- $order = &GetLastOrderNotReceivedFromSubscriptionid($subscriptionid); >- >-Returns a reference-to-hash describing the last order not received for a subscription. >- >-=cut >- >-sub GetLastOrderNotReceivedFromSubscriptionid { >- my ( $subscriptionid ) = @_; >- my $dbh = C4::Context->dbh; >- my $query = qq| >- SELECT * FROM aqorders >- LEFT JOIN subscription >- ON ( aqorders.subscriptionid = subscription.subscriptionid ) >- WHERE aqorders.subscriptionid = ? >- AND aqorders.datereceived IS NULL >- LIMIT 1 >- |; >- my $result_set = >- $dbh->selectall_arrayref( $query, { Slice => {} }, $subscriptionid ); >- >- # result_set assumed to contain 1 match >- return $result_set->[0]; >-} >- >-=head3 GetLastOrderReceivedFromSubscriptionid >- >- $order = &GetLastOrderReceivedFromSubscriptionid($subscriptionid); >- >-Returns a reference-to-hash describing the last order received for a subscription. >- >-=cut >- >-sub GetLastOrderReceivedFromSubscriptionid { >- my ( $subscriptionid ) = @_; >- my $lastOrderReceived = Koha::Acquisition::Orders->search( >- { >- subscriptionid => $subscriptionid, >- datereceived => { '!=' => undef } >- }, >- { >- order_by => >- [ { -desc => 'datereceived' }, { -desc => 'ordernumber' } ] >- } >- ); >- return $lastOrderReceived->count ? $lastOrderReceived->next->unblessed : undef; >-} >- >-#------------------------------------------------------------# >- > =head3 ModOrder > > &ModOrder(\%hashref); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20728
:
86693
|
86694
|
86695
|
99655
|
99656
|
99657
|
99877
|
99878
|
99879
|
102873
|
102874
|
102875