Bugzilla – Attachment 100212 Details for
Bug 24798
smart-rules.tt has erroneous comments
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24798: smart-rules.tt has erroneous comments
Bug-24798-smart-rulestt-has-erroneous-comments.patch (text/plain), 2.04 KB, created by
Marcel de Rooy
on 2020-03-06 07:44:04 UTC
(
hide
)
Description:
Bug 24798: smart-rules.tt has erroneous comments
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-03-06 07:44:04 UTC
Size:
2.04 KB
patch
obsolete
>From 709a69c53242f1542d59e78bc25ab67614351cbd Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 4 Mar 2020 18:29:24 +0000 >Subject: [PATCH] Bug 24798: smart-rules.tt has erroneous comments >Content-Type: text/plain; charset=utf-8 > >This patch corrects a couple of invalid Template Toolkit comments in the >Circulation and Fines rules template. > >To test, apply the patch and log into the staff client as an >administrator. > >On the Circulation and Fines Rules page "View source" and look for >instances of the text "[#% Default branch %#]" There should be none. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >[EDIT] There is a theoretical difference between [% # and [%#. The latter >marks the whole directive as a comment and not just until EOL. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index e0f50bf619..5ae3bb94e1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -719,7 +719,7 @@ > <tr> > <td> > <select name="refund"> >- [#% Default branch %#] >+ [%# Default branch %] > [% IF ( current_branch == '*' ) %] > [% IF ( defaultRefundRule ) %] > <option value="1" selected="selected"> >@@ -736,7 +736,7 @@ > No > </option> > [% ELSE %] >- [#% Branch-specific %#] >+ [%# Branch-specific %] > [% IF ( not refundLostItemFeeRule ) %] > <option value="*" selected="selected"> > [% ELSE %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24798
:
100143
|
100177
| 100212