Bugzilla – Attachment 102984 Details for
Bug 24380
Add option to recalculate fines upon a backdated return distinctly from `CalculateFinesOnReturn`
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24380: (QA follow-up) Do not use compare float with precision
Bug-24380-QA-follow-up-Do-not-use-compare-float-wi.patch (text/plain), 1.16 KB, created by
Jonathan Druart
on 2020-04-15 10:50:36 UTC
(
hide
)
Description:
Bug 24380: (QA follow-up) Do not use compare float with precision
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-04-15 10:50:36 UTC
Size:
1.16 KB
patch
obsolete
>From 4a14f3ee8c38097df88d15fe12c42ea600a0035f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 15 Apr 2020 12:48:44 +0200 >Subject: [PATCH] Bug 24380: (QA follow-up) Do not use compare float with > precision > >forbidden pattern: Do not use compare float with precision (bug 24408). > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Circulation/Returns.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t >index eadaa9f6af..864f47d79b 100644 >--- a/t/db_dependent/Circulation/Returns.t >+++ b/t/db_dependent/Circulation/Returns.t >@@ -437,7 +437,7 @@ subtest 'Backdated returns should reduce fine if needed' => sub { > my ( $doreturn, $messages, $issue ) = AddReturn($item->barcode, undef, undef, dt_from_string('1999-01-01') ); > > $fine->discard_changes; >- is( $fine->amountoutstanding, '0.000000', "Fine was reduced correctly with a backdated return" ); >+ is( $fine->amountoutstanding+0, 0, "Fine was reduced correctly with a backdated return" ); > }; > > $schema->storage->txn_rollback; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24380
:
97055
|
97544
|
97750
|
97751
|
97752
|
99536
|
99537
|
99538
|
102574
|
102575
|
102576
|
102577
|
102894
|
102895
|
102896
|
102981
|
102982
|
102983
| 102984 |
102985