Bugzilla – Attachment 103484 Details for
Bug 25250
JS code for checkboxes also affects hidden modules inputs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25250: [alternate] target checkboxes only
Bug-25250-alternate-target-checkboxes-only.patch (text/plain), 1.95 KB, created by
Nick Clemens (kidclamp)
on 2020-04-22 14:41:08 UTC
(
hide
)
Description:
Bug 25250: [alternate] target checkboxes only
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-04-22 14:41:08 UTC
Size:
1.95 KB
patch
obsolete
>From 3a50a781c49487a97069b36d72c07199825724ab Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 22 Apr 2020 14:40:17 +0000 >Subject: [PATCH] Bug 25250: [alternate] target checkboxes only > >--- > koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/viewlog.js b/koha-tmpl/intranet-tmpl/prog/js/viewlog.js >index ccec003ade..ca7f5a3aa3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/viewlog.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/viewlog.js >@@ -1,18 +1,18 @@ > function tickAll(section){ >- $("input[name='" + section + "']").prop("checked", true); >+ $("input[type='checkbox'][name='" + section + "']").prop("checked", true); > $("#" + section.slice(0,-1) + "ALL").prop("checked", true); >- $("input[name='" + section + "']").prop("disabled", true); >+ $("input[type='checkbox'][name='" + section + "']").prop("disabled", true); > $("#" + section.slice(0,-1) + "ALL").prop("disabled", false); > } > > function untickAll(section){ >- $("input[name='" + section + "']").prop("checked", false); >- $("input[name='" + section + "']").prop("disabled", false); >+ $("input[type='checkbox'][name='" + section + "']").prop("checked", false); >+ $("input[type='checkbox'][name='" + section + "']").prop("disabled", false); > } > > $(document).ready(function(){ > >- if ( $('input[name="modules"]:checked').length == 0 ) { >+ if ( $('input[type="checkbox"][name="modules"]:checked').length == 0 ) { > tickAll('modules'); > } > $("#moduleALL").change(function(){ >@@ -22,7 +22,7 @@ $(document).ready(function(){ > untickAll('modules'); > } > }); >- $("input[name='modules']").change(function(){ >+ $("input[type='checkbox'][name='modules']").change(function(){ > if ( $("input[name='modules']:checked").length == $("input[name='modules']").length - 1 ){ > tickAll('modules'); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25250
:
103478
|
103479
|
103484
|
103486
|
103487
|
103747