Bugzilla – Attachment 103878 Details for
Bug 25300
Edit details in "Library use" section uses bad $op for Expiration Date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25300: Fix typo in "Edit details" for expiring/expired patron
Bug-25300-Fix-typo-in-Edit-details-for-expiringexp.patch (text/plain), 3.62 KB, created by
Katrin Fischer
on 2020-04-28 18:52:02 UTC
(
hide
)
Description:
Bug 25300: Fix typo in "Edit details" for expiring/expired patron
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-04-28 18:52:02 UTC
Size:
3.62 KB
patch
obsolete
>From ac57058a8c82a039a310e8360345b9d67c6d192e Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 28 Apr 2020 12:00:15 +1000 >Subject: [PATCH] Bug 25300: Fix typo in "Edit details" for expiring/expired > patron >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch removes a typo in the argument to the "op" parameter >for the "Edit details" link when editing an expiring/expired patron >on the Details page. > >Test plan: >0. Do not apply patch yet >1. Create patron >2. Set expiry date to 3 days from now >3. Go to Details tab in patron record >4. Click "Edit details" in "Library use" section >5. Note the form is blank and has no patron data in it >6. Apply the patch >7. Reload the Details page in patron record >8. Click "Edit details" in "Library use" section >9. Note the form now contains your patron data and will >work for editing the details > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> >See the typo, the bug before/after > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 15ea33c9f0..071c728605 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -462,12 +462,12 @@ > <span class="blocker"> > [% patron.dateexpiry | $KohaDates %] > <strong><em>Expired</em></strong> >- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify]&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> > </span> > [% ELSIF ( patron.is_going_to_expire ) %] > [% patron.dateexpiry | $KohaDates %] > <strong><em>Patron expires soon</em></strong> >- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify]&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> > [% ELSE %] > [% patron.dateexpiry | $KohaDates %] > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25300
:
103820
|
103821
| 103878