From 41f1d6570f1c2963feb5fda65ab1adb8b469b594 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 00:34:43 +1200 Subject: [PATCH] Bug 6679 - fix 12 perlcritic violations in C4/Context.pm Content-Type: text/plain; charset="utf-8" http://koha-community.org "return" statement with explicit "undef" at line 486, column 5. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 548, column 1. See page 194 of PBP. (Severity: 5) --- C4/Context.pm | 24 ++++++++++++------------ 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/C4/Context.pm b/C4/Context.pm index 9ce6c74..a602f11 100644 --- a/C4/Context.pm +++ b/C4/Context.pm @@ -276,7 +276,7 @@ sub memcached { if ($ismemcached) { return $memcached; } else { - return undef; + return; } } @@ -293,7 +293,7 @@ sub db_scheme2dbi { if (/Postgres|Pg|PostgresSQL/) { return("Pg"); } if (/oracle/) { return("Oracle"); } } - return undef; # Just in case + return; # Just in case } sub import { @@ -358,7 +358,7 @@ sub new { $conf_fname = CONFIG_FNAME; } else { warn "unable to locate Koha configuration file koha-conf.xml"; - return undef; + return; } } @@ -376,7 +376,7 @@ sub new { $self->{"config_file"} = $conf_fname; warn "read_config_file($conf_fname) returned undef" if !defined($self->{"config"}); - return undef if !defined($self->{"config"}); + return if !defined($self->{"config"}); $self->{"dbh"} = undef; # Database handle $self->{"Zconn"} = undef; # Zebra Connections @@ -480,10 +480,10 @@ Cnew> will not return it. =cut -sub _common_config ($$) { +sub _common_config { my $var = shift; my $term = shift; - return undef if !defined($context->{$term}); + return if !defined($context->{$term}); # Presumably $self->{$term} might be # undefined if the config file given to &new # didn't exist, and the caller didn't bother @@ -545,7 +545,7 @@ END_SQL return $sysprefs{$var}; } -sub boolean_preference ($) { +sub boolean_preference { my $self = shift; my $var = shift; # The system preference to return my $it = preference($self, $var); @@ -1027,19 +1027,19 @@ sub set_userenv { return $cell; } -sub set_shelves_userenv ($$) { - my ($type, $shelves) = @_ or return undef; - my $activeuser = $context->{activeuser} or return undef; +sub set_shelves_userenv { + my ($type, $shelves) = @_ or return; + my $activeuser = $context->{activeuser} or return; $context->{userenv}->{$activeuser}->{barshelves} = $shelves if $type eq 'bar'; $context->{userenv}->{$activeuser}->{pubshelves} = $shelves if $type eq 'pub'; $context->{userenv}->{$activeuser}->{totshelves} = $shelves if $type eq 'tot'; } -sub get_shelves_userenv () { +sub get_shelves_userenv { my $active; unless ($active = $context->{userenv}->{$context->{activeuser}}) { $debug and warn "get_shelves_userenv cannot retrieve context->{userenv}->{context->{activeuser}}"; - return undef; + return; } my $totshelves = $active->{totshelves} or undef; my $pubshelves = $active->{pubshelves} or undef; -- 1.7.2.5