From 97ae1da7c572758ba0e99e51fd0b0117416c0562 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 29 May 2020 16:10:58 +0200 Subject: [PATCH] Bug 25622: Use special chars in DB password (koha-create) On bug 23250 we decided to generate a password without special chars then add a '@' at the end to comply with MySQL policy. That is wrong, we should handle correctly the special chars we don't want to be part of the password. Test plan: 1. mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1) echo $mysqlpwd Confirm that you don't see one of the following chars : ' & \ < > / 2. Copy from src and edit /usr/sbin/koha-create to add an echo $mysqlpwd Create several instances, like: koha-create --create-db x koha-create --create-db xx koha-create --create-db xxx ... When you see a password with a special chars, do: koha-shell xxx grep '' $KOHA_CONF And make sure the password does not contain "__DB_PASS__" Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Julian Maurice --- debian/scripts/koha-create | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/scripts/koha-create b/debian/scripts/koha-create index b90e7d4e23..5a11bdd371 100755 --- a/debian/scripts/koha-create +++ b/debian/scripts/koha-create @@ -592,8 +592,8 @@ if [ "$op" = create ] || [ "$op" = request ] || [ "$op" = use ] then if [ "$mysqlpwd" = "" ] then - mysqlpwd="$(pwgen -s 15 1)" - mysqlpwd="$mysqlpwd@" + # Removing : ' & \ < > / + mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1) fi else mysqlpwd="$(getinstancemysqlpassword $name)" -- 2.20.1