Bugzilla – Attachment 107854 Details for
Bug 26151
Remove the use of jquery.checkboxes plugin from suggestions management page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page
Bug-26151-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.23 KB, created by
Owen Leonard
on 2020-08-05 17:32:51 UTC
(
hide
)
Description:
Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-08-05 17:32:51 UTC
Size:
2.23 KB
patch
obsolete
>From 5bb845df3f78b25e8d37f96624a3338cf284d3e5 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 5 Aug 2020 17:27:58 +0000 >Subject: [PATCH] Bug 26151: Remove the use of jquery.checkboxes plugin from > suggestions management page > >This patch removes the use of the jquery.checkboxes plugin from the >suggestions management page and replaces it with custom JS. > >To test, apply the patch and go to Acquisitions -> Suggestions > >Under each tab ("Accepted," "Pending," etc.), test that the "Check all" >and "Uncheck all" controls work correctly and only affect the table on >that tab. >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index c293a57ba3..0821d4459c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -998,8 +998,6 @@ > [% IF op == 'else' %] > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'columns_settings.inc' %] >- [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] >- > <script> > $(document).ready(function() { > $('#suggestiontabs').tabs(); >@@ -1020,13 +1018,15 @@ > > $(".checkall").click(function(e){ > e.preventDefault(); >- $(this).parents('form').checkCheckboxes(); >- return false; >+ $(this).parents('form').find("input:checkbox").each(function(){ >+ $(this).prop("checked", true); >+ }); > }); > $(".uncheckall").click(function(e){ > e.preventDefault(); >- $(this).parents('form').unCheckCheckboxes(); >- return false; >+ $(this).parents('form').find("input:checkbox").each(function(){ >+ $(this).prop("checked", false); >+ }); > }); > $(".other_reason").hide(); > $("select[name='reason']").change(function(){ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26151
:
107854
|
110112
|
110125