Bugzilla – Attachment 107873 Details for
Bug 26134
Error when adding to basket from new/staged file when using MARCItemFieldsToOrder
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file
Bug-26134-bug-23463-follow-up-Fix-add-to-basket-fr.patch (text/plain), 1.39 KB, created by
Jonathan Druart
on 2020-08-06 10:52:25 UTC
(
hide
)
Description:
Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-06 10:52:25 UTC
Size:
1.39 KB
patch
obsolete
>From b6aa45306d36df412ed24dc181c1ab094189c669 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Aug 2020 12:50:36 +0200 >Subject: [PATCH] Bug 26134: (bug 23463 follow-up) Fix add to basket from > staged file > >There is a ->store call missing when we attempt to create a new item. > >Test plan: >- set at least one value in MARCItemFieldsToOrder >- add to a basket via staged file with at least one value matching your MARCItemFields mappings >- set required fields for your order and click Save >=> Without this patch you got: >receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77" >=> With this patch applied the order has been created successfully >--- > acqui/addorderiso2709.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl >index 8d394d3ca5..91c301735d 100755 >--- a/acqui/addorderiso2709.pl >+++ b/acqui/addorderiso2709.pl >@@ -237,7 +237,7 @@ if ($op eq ""){ > replacementprice => $replacementprices[$i], > itemcallnumber => $itemcallnumbers[$i], > } >- ); >+ )->store; > push( @itemnumbers, $item->itemnumber ); > } > if ($itemcreation == 1) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26134
:
107873
|
108158
|
108316