Bugzilla – Attachment 108170 Details for
Bug 18501
Automatic refunds need protection from failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18501: (QA follow-up) Add POD for Koha::Item->set_found
Bug-18501-QA-follow-up-Add-POD-for-KohaItem-setfou.patch (text/plain), 1.47 KB, created by
Martin Renvoize
on 2020-08-13 09:46:17 UTC
(
hide
)
Description:
Bug 18501: (QA follow-up) Add POD for Koha::Item->set_found
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-08-13 09:46:17 UTC
Size:
1.47 KB
patch
obsolete
>From d122ea547025b0aa8f0be19603663590f629f74d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 13 Aug 2020 10:26:37 +0100 >Subject: [PATCH] Bug 18501: (QA follow-up) Add POD for Koha::Item->set_found > >This patch adds a simple POD entry for the new 'set_found' method >introduced in this patchset. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Item.pm | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 624392deb1..2df7e17d53 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -762,12 +762,29 @@ sub renewal_branchcode { > return $branchcode; > } > >+=head3 set_found >+ >+ my $lost_item_refunded; >+ if ( $item->itemlost ) { >+ $lost_item_refunded = $item->set_found; >+ } >+ >+Function to set a previously lost item to found. >+ >+The action will update the item details and trigger >+any refunds that may result from the items return. >+ >+Returns a boolean denoting whether the action triggered >+a refund or not. >+ >+=cut >+ > sub set_found { > my ($self, $params) = @_; > > my $holdingbranch = $params->{holdingbranch} || $self->holdingbranch; > >- ## If item was lost, it has now been found, reverse any list item charges if necessary. >+ ## If item was lost, it has now been found, reverse any lost item charges if necessary. > my $refund = 1; > my $no_refund_after_days = > C4::Context->preference('NoRefundOnLostReturnedItemsAge'); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18501
:
108004
|
108005
|
108006
|
108121
|
108122
|
108123
|
108167
|
108168
|
108169
|
108170
|
108193
|
108194
|
108195
|
108243
|
108248
|
108249
|
108291
|
108292
|
108293
|
108294
|
108295
|
108296
|
108297
|
108298
|
108299
|
108300
|
108301
|
108482
|
108483
|
108484
|
108485
|
108486
|
108487
|
108488
|
108489
|
108490
|
108491
|
108492
|
108493
|
108494
|
108575
|
108576
|
108577
|
108578
|
108579
|
108580
|
108581
|
108582
|
108583
|
108584
|
108585
|
108586
|
108596
|
108597
|
108598
|
108599
|
108600
|
108601
|
108602
|
108603
|
108604
|
108605
|
108606
|
108607
|
108608
|
108610
|
108611
|
108612
|
108613
|
108614
|
108615
|
108616
|
108617
|
108618
|
108619
|
108620
|
108621
|
108717
|
108732
|
108738
|
108739
|
108740
|
108741
|
108784
|
108785
|
108786
|
108787
|
108788
|
108795
|
111295