From fbe6136a4487d39772d44197c8a7dd8c14dfcb0f Mon Sep 17 00:00:00 2001 From: David Cook Date: Tue, 18 Aug 2020 12:20:32 +1000 Subject: [PATCH] Bug 26231: Remove incorrect use of AddAuthority() when 001 present This patch removes the use of AddAuthority with a non-empty authid argument, since that triggers an update rather than an insert. In practice, the update also fails, but the error isn't raised, as the database connection doesn't have RaiseError set. Test plan: 1) Do not apply patch 2) Try to bulkmarcimport an authority file with a 001 3) Observe that the script reports success but no authority is added 4) Apply the path 5) Try to bulkmarcimport an authority file with a 001 6) Observe that the script reports success and the authority is added --- misc/migration_tools/bulkmarcimport.pl | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index 6e9ea0b3ad..f1a625186a 100755 --- a/misc/migration_tools/bulkmarcimport.pl +++ b/misc/migration_tools/bulkmarcimport.pl @@ -397,17 +397,6 @@ RECORD: while ( ) { printlog({id=>$originalid||$id||$authid, op=>"edit",status=>"ok"}) if ($logfile); } } - elsif (defined $authid) { - ## An authid is defined but no authority in database : add - eval { ( $authid ) = AddAuthority($record,$authid, $authtypecode) }; - if ($@){ - warn "Problem with authority $authid Cannot Add ".$@; - printlog({id=>$originalid||$id||$authid, op=>"insert",status=>"ERROR"}) if ($logfile); - } - else{ - printlog({id=>$originalid||$id||$authid, op=>"insert",status=>"ok"}) if ($logfile); - } - } else { ## True insert in database eval { ( $authid ) = AddAuthority($record,"", $authtypecode) }; -- 2.16.4