From 37b4b241d4b68e483d8dbb180fa8a454e62b3231 Mon Sep 17 00:00:00 2001 From: David Cook Date: Mon, 16 Jul 2012 14:13:31 +1000 Subject: [PATCH] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt Content-Type: text/plain; charset="utf-8" When you cancel a hold in the "Hold Waiting" tab of Holds Awaiting Pickup, you should be prompted to retain or transfer the hold for the next patron in the queue. However, instead of seeing this prompt, you are just shown white screen that fails to alert you to the fact that there are more holds on that item! There is a missing FOREACH reference in waitingreserves.tt. The template tries to directly reference the hash within the cancel_results array, but we need to access the array before we can access the hash. --- .../prog/en/modules/circ/waitingreserves.tt | 44 ++++++++++--------- 1 files changed, 23 insertions(+), 21 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt index 0101d7f..4791038 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt @@ -45,27 +45,29 @@ $.tablesorter.addParser({ [% END %] [% IF ( cancel_result ) %] - [% IF ( cancel_result.messagetransfert ) %] -
-

Hold find for ([% nextreservtitle %]), must be transferred

-

This hold placed by : [% nextreservsurname %] [% nextreservfirstname %] at the library : [% branchname %] , Please transfer this hold. -

-
- -
-
- [% END %] - [% IF ( cancel_result.waiting ) %] -
-

This hold is waiting

-

This hold ([% nextreservtitle %]) was placed by : [% nextreservsurname %] [% nextreservfirstname %], - Please retain this hold. -

-
- -
-
- [% END %] + [% FOREACH cancel_result %] + [% IF ( messagetransfert ) %] +
+

Hold find for ([% nextreservtitle %]), must be transferred

+

This hold placed by : [% nextreservsurname %] [% nextreservfirstname %] at the library : [% branchname %] , Please transfer this hold. +

+
+ +
+
+ [% END %] + [% IF ( waiting ) %] +
+

This hold is waiting

+

This hold ([% nextreservtitle %]) was placed by : [% nextreservsurname %] [% nextreservfirstname %], + Please retain this hold. +

+
+ +
+
+ [% END %] + [% END %] [% ELSE %]