From af5d9032babb4a7426057bc93df1f151cdd8e9c1 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 24 Aug 2020 11:31:20 +0200 Subject: [PATCH] Bug 25534: Use build_sample_item in tests --- t/db_dependent/Koha/Holds.t | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/t/db_dependent/Koha/Holds.t b/t/db_dependent/Koha/Holds.t index 007c073e61..2282290329 100644 --- a/t/db_dependent/Koha/Holds.t +++ b/t/db_dependent/Koha/Holds.t @@ -255,17 +255,8 @@ subtest 'cancel' => sub { subtest 'cancel with reason' => sub { plan tests => 7; - my $biblioitem = $builder->build_object( { class => 'Koha::Biblioitems' } ); my $library = $builder->build_object( { class => 'Koha::Libraries' } ); - my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes', value => { rentalcharge => 0 } } ); - my $item_info = { - biblionumber => $biblioitem->biblionumber, - biblioitemnumber => $biblioitem->biblioitemnumber, - homebranch => $library->branchcode, - holdingbranch => $library->branchcode, - itype => $itemtype->itemtype, - }; - my $item = $builder->build_object( { class => 'Koha::Items', value => $item_info } ); + my $item = $builder->build_sample_item({ library => $library->branchcode }); my $manager = $builder->build_object( { class => "Koha::Patrons" } ); t::lib::Mocks::mock_userenv( { patron => $manager, branchcode => $manager->branchcode } ); @@ -322,17 +313,8 @@ subtest 'cancel with reason' => sub { subtest 'cancel all with reason' => sub { plan tests => 7; - my $biblioitem = $builder->build_object( { class => 'Koha::Biblioitems' } ); my $library = $builder->build_object( { class => 'Koha::Libraries' } ); - my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes', value => { rentalcharge => 0 } } ); - my $item_info = { - biblionumber => $biblioitem->biblionumber, - biblioitemnumber => $biblioitem->biblioitemnumber, - homebranch => $library->branchcode, - holdingbranch => $library->branchcode, - itype => $itemtype->itemtype, - }; - my $item = $builder->build_object( { class => 'Koha::Items', value => $item_info } ); + my $item = $builder->build_sample_item({ library => $library->branchcode }); my $manager = $builder->build_object( { class => "Koha::Patrons" } ); t::lib::Mocks::mock_userenv( { patron => $manager, branchcode => $manager->branchcode } ); -- 2.20.1