From 1ad9dcbd3eb4874ced8874d3584b1bcfc1cb7af5 Mon Sep 17 00:00:00 2001 From: Mason James Date: Tue, 26 Jun 2012 16:39:27 +1200 Subject: [PATCH] Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm Bareword file handle opened at line 558, column 17. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 558, column 17. See page 207 of PBP. (Severity: 5) http://bugs.koha-community.org/show_bug.cgi?id=6679 Signed-off-by: Jonathan Druart --- C4/ImportExportFramework.pm | 48 ++++++++++++++++++++++-------------------- 1 files changed, 25 insertions(+), 23 deletions(-) diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm index b81b393..72873f2 100644 --- a/C4/ImportExportFramework.pm +++ b/C4/ImportExportFramework.pm @@ -515,7 +515,7 @@ sub _createTmpDir mkdir $tempdir; }; if ($@) { - return undef; + return; } else { return $tempdir; } @@ -547,27 +547,28 @@ sub createODS $tempdir = _createTmpDir($tmp); } if ($tempdir) { + my $fh; # populate tempdir directory with the ods elements eval { - if (open(OUT, "> $tempdir/content.xml")) { - print OUT $strContent; - close(OUT); + if (open($fh, '>', "$tempdir/content.xml")) { + print {$fh} $strContent; + close($fh); } - if (open(OUT, "> $tempdir/mimetype")) { - print OUT 'application/vnd.oasis.opendocument.spreadsheet'; - close(OUT); + if (open($fh, '>', "$tempdir/mimetype")) { + print {$fh} 'application/vnd.oasis.opendocument.spreadsheet'; + close($fh); } - if (open(OUT, "> $tempdir/meta.xml")) { - print OUT _getMeta($lang); - close(OUT); + if (open($fh, '>', "$tempdir/meta.xml")) { + print {$fh} _getMeta($lang); + close($fh); } - if (open(OUT, "> $tempdir/styles.xml")) { - print OUT ODS_STYLES_STR; - close(OUT); + if (open($fh, '>', "$tempdir/styles.xml")) { + print {$fh} ODS_STYLES_STR; + close($fh); } - if (open(OUT, "> $tempdir/settings.xml")) { - print OUT ODS_SETTINGS_STR; - close(OUT); + if (open($fh, '>', "$tempdir/settings.xml")) { + print {$fh} ODS_SETTINGS_STR; + close($fh); } mkdir($tempdir.'/META-INF/'); mkdir($tempdir.'/Configurations2/'); @@ -579,9 +580,10 @@ sub createODS mkdir($tempdir.'/Configurations2/menubar/'); mkdir($tempdir.'/Configurations2/progressbar/'); mkdir($tempdir.'/Configurations2/toolbar/'); - if (open(OUT, "> $tempdir/META-INF/manifest.xml")) { - print OUT ODS_MANIFEST_STR; - close(OUT); + + if (open($fh, '>', "$tempdir/META-INF/manifest.xml")) { + print {$fh} ODS_MANIFEST_STR; + close($fh); } }; if ($@) { @@ -604,13 +606,13 @@ sub createODS my $ok = 0; # read ods file and return as a string if (-f "$tempdir/new.ods") { - if (open (MYFILE, "$tempdir/new.ods")) { - binmode MYFILE; + if (open ($fh, '<', "$tempdir/new.ods")) { + binmode $fh; my $buffer; - while (read (MYFILE, $buffer, 65536)) { + while (read ($fh, $buffer, 65536)) { $$strODSRef .= $buffer; } - close(MYFILE); + close($fh); $ok = 1; } } -- 1.7.7.3