From b26333a5e19f6c915b820dbf8f6af7e03645aeb1 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 02:41:20 +1200 Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm Expression form of "eval" at line 358, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 367, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 510, column 3. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart --- C4/Record.pm | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Record.pm b/C4/Record.pm index a07fcfc..1d24210 100644 --- a/C4/Record.pm +++ b/C4/Record.pm @@ -383,7 +383,7 @@ sub marc2csv { } # Preprocessing - eval $preprocess if ($preprocess); + eval {$preprocess} if ($preprocess); my $firstpass = 1; foreach my $biblio (@$biblios) { @@ -392,7 +392,7 @@ sub marc2csv { } # Postprocessing - eval $postprocess if ($postprocess); + eval {$postprocess} if ($postprocess); return $output; } @@ -535,7 +535,7 @@ sub marcrecord2csv { $value = defined $authvalues->{$_->as_string} ? $authvalues->{$_->as_string} : $_->as_string; # Field processing - eval $fieldprocessing if ($fieldprocessing); + eval {$fieldprocessing} if ($fieldprocessing); push @valuesarray, $value; } -- 1.7.7.3