From 23f1432bdf700ce80b4c27a083acdd1c6c013413 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 02:48:25 +1200 Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm "return" statement with explicit "undef" at line 109, column 9. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 145, column 9. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 319, column 9. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart --- C4/Message.pm | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Message.pm b/C4/Message.pm index 5386968..a63b3ca 100644 --- a/C4/Message.pm +++ b/C4/Message.pm @@ -106,7 +106,7 @@ sub find { if (@$msgs) { return $class->new($msgs->[0]); } else { - return undef; + return; } } @@ -142,7 +142,7 @@ sub find_last_message { if (@$msgs) { return $class->new($msgs->[0]); } else { - return undef; + return; } } @@ -316,7 +316,7 @@ sub append { } if (not $self->metadata) { carp "Can't append to messages that don't have metadata."; - return undef; + return; } my $metadata = $self->metadata; push @{$metadata->{body}}, $item; -- 1.7.7.3