Bugzilla – Attachment 111416 Details for
Bug 26648
Prevent internal server error if item attached to old checkout has been removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26648: Prevent explosion on missin item
Bug-26648-Prevent-explosion-on-missin-item.patch (text/plain), 1.24 KB, created by
Martin Renvoize
on 2020-10-09 15:16:39 UTC
(
hide
)
Description:
Bug 26648: Prevent explosion on missin item
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-10-09 15:16:39 UTC
Size:
1.24 KB
patch
obsolete
>From 69ff3a91a5d1f06e7c7754627dd1bb625478a34d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 9 Oct 2020 16:13:00 +0100 >Subject: [PATCH] Bug 26648: Prevent explosion on missin item > >The item accessor in Koha::Old::Checkouts could explode given a checkout >where the item had been deleted. > >To test >1/ Edit the issueslip notice to output some item details from the >borrowers old checkouts > >[% FOREACH old_checkout IN borrower.old_checkouts %] > [% IF old_checkout.item %] > [% old_checkout.item.price %] > [% END %] >[% END %] > >2/ Delete the item associated with an old checkout for a test patron >3/ Print the issueslip for the patron >4/ Note a server side error is triggered >5/ Apply the patch >6/ Print the slip again and note the price details for old checkouts are >now displayed >7/ Signoff >--- > Koha/Old/Checkout.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/Koha/Old/Checkout.pm b/Koha/Old/Checkout.pm >index 9dbc58e3a8..b3e3bc24cc 100644 >--- a/Koha/Old/Checkout.pm >+++ b/Koha/Old/Checkout.pm >@@ -40,6 +40,7 @@ Return the checked out item > sub item { > my ( $self ) = @_; > my $item_rs = $self->_result->item; >+ return unless $item_rs; > return Koha::Item->_new_from_dbic( $item_rs ); > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26648
:
111416
|
111435
|
111804
|
141287
|
141333
|
141334
|
141382