From f2009099500ce677dc1efd6324aeba9e7eafa637 Mon Sep 17 00:00:00 2001 From: Jared Camins-Esakov Date: Mon, 30 Jul 2012 14:09:25 -0400 Subject: [PATCH] Bug 8268: improve error checking Content-Type: text/plain; charset="UTF-8" Valid download attempts were being denied thanks to an incorrect regular expression. This patch fixes that, and makes it easier to understand what's going on in the code. --- tools/export.pl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/export.pl b/tools/export.pl index af358e6..a62adf7 100755 --- a/tools/export.pl +++ b/tools/export.pl @@ -345,7 +345,8 @@ sub download_backup { my $filename = $args->{filename}; return unless ( $directory && -d $directory ); - return unless ( $filename =~ m/$extension(\.(gz|bz2|xz))?$/ && not $filename =~ m#|# ); + return unless ( $filename =~ m/\.$extension(\.(gz|bz2|xz))?$/ ); + return if ( $filename =~ m#/# ); $filename = "$directory/$filename"; return unless ( -f $filename && -o $filename ); return unless ( open(my $dump, '<', $filename) ); -- 1.7.2.5