Bugzilla – Attachment 112824 Details for
Bug 22806
CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22806: Remove perlcritic errors
Bug-22806-Remove-perlcritic-errors.patch (text/plain), 1.41 KB, created by
Jonathan Druart
on 2020-11-02 10:30:32 UTC
(
hide
)
Description:
Bug 22806: Remove perlcritic errors
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-11-02 10:30:32 UTC
Size:
1.41 KB
patch
obsolete
>From 8ccd4e1116ec5cb37cc0b5033f5e3520f1f12790 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 2 Nov 2020 11:30:04 +0100 >Subject: [PATCH] Bug 22806: Remove perlcritic errors > >Subroutine "new" called using indirect syntax at line 415, column 18. See page 349 of PBP. (Severity: 4) >Subroutine "new" called using indirect syntax at line 420, column 14. See page 349 of PBP. (Severity: 4) >--- > t/db_dependent/ILSDI_Services.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index c721a2496d..5e38a12df2 100755 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -412,12 +412,12 @@ subtest 'Holds test' => sub { > $reply = C4::ILSDI::Services::HoldItem( $query ); > is( $reply->{code}, 'damaged', "Item is damaged" ); > >- my $module = new Test::MockModule('C4::Context'); >+ my $module = Test::MockModule->new('C4::Context'); > $module->mock('userenv', sub { { patron => $patron } }); > my $issue = C4::Circulation::AddIssue($patron, $item3->barcode); > t::lib::Mocks::mock_preference( 'AllowHoldsOnPatronsPossessions', '0' ); > >- $query = new CGI; >+ $query = CGI->new; > $query->param( 'patron_id', $patron->{borrowernumber}); > $query->param( 'bib_id', $item3->biblionumber); > $query->param( 'item_id', $item3->itemnumber); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22806
:
89039
|
89724
|
91784
|
94388
|
94389
|
97947
|
99881
|
99882
|
99883
|
99884
|
99885
|
100091
|
100092
|
100093
|
100173
|
100174
|
100175
|
106564
|
106778
|
106779
|
106780
|
107760
|
107806
|
110100
|
110101
|
110102
|
110973
|
110974
|
110975
|
110976
|
111771
|
111772
|
111773
|
111774
| 112824