View | Details | Raw Unified | Return to bug 23916
Collapse All | Expand All

(-)a/t/db_dependent/Circulation.t (-2 / +49 lines)
Lines 18-24 Link Here
18
use Modern::Perl;
18
use Modern::Perl;
19
use utf8;
19
use utf8;
20
20
21
use Test::More tests => 50;
21
use Test::More tests => 51;
22
use Test::Exception;
22
use Test::Exception;
23
use Test::MockModule;
23
use Test::MockModule;
24
use Test::Deep qw( cmp_deeply );
24
use Test::Deep qw( cmp_deeply );
Lines 121-126 for my $branch ( $branches->next ) { Link Here
121
$dbh->do('DELETE FROM issues');
121
$dbh->do('DELETE FROM issues');
122
$dbh->do('DELETE FROM borrowers');
122
$dbh->do('DELETE FROM borrowers');
123
123
124
# Disable recording of issuer until we're ready for it
125
t::lib::Mocks::mock_preference('RecordIssuer', 0);
126
127
my $module = new Test::MockModule('C4::Context');
128
124
my $library = $builder->build({
129
my $library = $builder->build({
125
    source => 'Branch',
130
    source => 'Branch',
126
});
131
});
Lines 3345-3351 subtest 'Incremented fee tests' => sub { Link Here
3345
    my $library =
3350
    my $library =
3346
      $builder->build_object( { class => 'Koha::Libraries' } )->store;
3351
      $builder->build_object( { class => 'Koha::Libraries' } )->store;
3347
3352
3348
    my $module = Test::MockModule->new('C4::Context');
3349
    $module->mock( 'userenv', sub { { branch => $library->id } } );
3353
    $module->mock( 'userenv', sub { { branch => $library->id } } );
3350
3354
3351
    my $patron = $builder->build_object(
3355
    my $patron = $builder->build_object(
Lines 4147-4152 subtest 'Checkout should correctly terminate a transfer' => sub { Link Here
4147
    $hold = $hold->get_from_storage;
4151
    $hold = $hold->get_from_storage;
4148
    is( $hold->found, undef, 'Hold is waiting' );
4152
    is( $hold->found, undef, 'Hold is waiting' );
4149
    is( $hold->priority, 1, );
4153
    is( $hold->priority, 1, );
4154
}
4155
4156
subtest 'AddIssue records issuer if appropriate' => sub  {
4157
    plan tests => 2;
4158
4159
    $module->mock( 'userenv', sub { { branch => $library->{id} } } );
4160
4161
    my $library =
4162
      $builder->build_object( { class => 'Koha::Libraries' } )->store;
4163
    my $patron = $builder->build_object(
4164
        {
4165
            class => 'Koha::Patrons',
4166
            value => { categorycode => $patron_category->{categorycode} }
4167
        }
4168
    )->store;
4169
    my $issuer = $builder->build_object(
4170
        {
4171
            class => 'Koha::Patrons',
4172
            value => { categorycode => $patron_category->{categorycode} }
4173
        }
4174
    )->store;
4175
    my $item = $builder->build_sample_item(
4176
        {
4177
            library  => $library->{branchcode}
4178
        }
4179
    );
4180
4181
    $module->mock( 'userenv', sub { { branch => $library->id, number => $issuer->{borrowernumber} } } );
4182
4183
    my $dt_from     = dt_from_string();
4184
    my $dt_to       = dt_from_string()->add( days => 7 );
4185
4186
    my $issue =
4187
      AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4188
4189
    is( $issue->issuer, undef, "Issuer not recorded when RecordIssuer turned off" );
4190
4191
    t::lib::Mocks::mock_preference('RecordIssuer', 1);
4192
4193
    my $issue2 =
4194
      AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4195
4196
    is( $issue->issuer, $issuer->{borrowernumber}, "Issuer recorded when RecordIssuer turned on" );
4150
};
4197
};
4151
4198
4152
$schema->storage->txn_rollback;
4199
$schema->storage->txn_rollback;
(-)a/t/db_dependent/Koha/Checkouts.t (-1 / +30 lines)
Lines 19-25 Link Here
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
21
22
use Test::More tests => 7;
22
use Test::More tests => 8;
23
23
24
use C4::Circulation;
24
use C4::Circulation;
25
use Koha::Checkouts;
25
use Koha::Checkouts;
Lines 122-127 subtest 'patron' => sub { Link Here
122
    );
122
    );
123
};
123
};
124
124
125
subtest 'issuer' => sub {
126
    plan tests => 3;
127
    my $patron = $builder->build_object({class=>'Koha::Patrons', value => {branchcode => $library->{branchcode}}});
128
    my $issuer = $builder->build_object({class=>'Koha::Patrons', value => {branchcode => $library->{branchcode}}});
129
130
    my $item = $builder->build_object( { class=> 'Koha::Items' } );
131
    my $checkout = Koha::Checkout->new({
132
        borrowernumber => $patron->borrowernumber,
133
        issuer         => $issuer->borrowernumber,
134
        itemnumber     => $item->itemnumber,
135
        branchcode     => $library->{branchcode},
136
    })->store;
137
138
    my $i = $checkout->issued_by;
139
    is( ref($i), 'Koha::Patron',
140
        'Koha::Checkout->issued_by should return a Koha::Patron' );
141
    is( $i->borrowernumber, $issuer->borrowernumber,
142
        'Koha::Checkout->issued_by should return the correct patron' );
143
144
    my $issue_id = $checkout->issue_id;
145
    C4::Circulation::MarkIssueReturned( $i->borrowernumber, $checkout->itemnumber );
146
    $i->delete;
147
    my $old_issue = Koha::Old::Checkouts->find($issue_id);
148
    is( $old_issue->issuer, undef,
149
        'Koha::Checkout->issuer should return undef if the patron record has been deleted'
150
    );
151
152
};
153
125
$retrieved_checkout_1->delete;
154
$retrieved_checkout_1->delete;
126
is( Koha::Checkouts->search->count, $nb_of_checkouts + 1, 'Delete should have deleted the checkout' );
155
is( Koha::Checkouts->search->count, $nb_of_checkouts + 1, 'Delete should have deleted the checkout' );
127
156
(-)a/t/db_dependent/Koha/Patrons.t (-1 / +7 lines)
Lines 1419-1424 subtest 'get_overdues' => sub { Link Here
1419
            value  => { branchcode => $library->{branchcode} }
1419
            value  => { branchcode => $library->{branchcode} }
1420
        }
1420
        }
1421
    );
1421
    );
1422
    my $issuer = $builder->build(
1423
        {
1424
            source => 'Borrower',
1425
            value  => { branchcode => $library->{branchcode} }
1426
        }
1427
    );
1428
    t::lib::Mocks::mock_userenv({ number => $issuer->{borrowernumber} });
1422
1429
1423
    t::lib::Mocks::mock_preference({ branchcode => $library->{branchcode} });
1430
    t::lib::Mocks::mock_preference({ branchcode => $library->{branchcode} });
1424
1431
1425
- 

Return to bug 23916