Bugzilla – Attachment 113776 Details for
Bug 24488
Holds to Pull sometimes shows the wrong 'first patron' details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24488: perf - move patrons_count out of the loop
Bug-24488-perf---move-patronscount-out-of-the-loop.patch (text/plain), 1.79 KB, created by
Jonathan Druart
on 2020-11-18 10:54:13 UTC
(
hide
)
Description:
Bug 24488: perf - move patrons_count out of the loop
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-11-18 10:54:13 UTC
Size:
1.79 KB
patch
obsolete
>From f404ceb673500ccbd1f54959ca15b7a8315048f3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 18 Nov 2020 11:14:10 +0100 >Subject: [PATCH] Bug 24488: perf - move patrons_count out of the loop > >--- > circ/pendingreserves.pl | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 0bc6995768..9cad99ab8f 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -209,6 +209,18 @@ foreach my $item ( @all_items ) { > push @{$all_items->{$item->biblionumber}}, $item; > } > >+# patrons count per biblio >+my $patrons_count = { >+ map { $_->{biblionumber} => $_->{patrons_count} } @{ Koha::Holds->search( >+ {}, >+ { >+ select => [ 'biblionumber', { count => { distinct => 'borrowernumber' } } ], >+ as => [qw( biblionumber patrons_count )], >+ group_by => [qw( biblionumber )] >+ }, >+ )->unblessed >+ } >+}; > > # make final reserves hash and fill with info > my $reserves; >@@ -253,13 +265,9 @@ foreach my $bibnum ( @biblionumbers ){ > $reserves->{$bibnum}->{items_count} = $items_count; > > # patrons with holds >- my $patrons_count = Koha::Holds->search( >- { biblionumber => $bibnum }, >- { distinct => 1, columns => qw(me.borrowernumber) } >- )->count; >- $reserves->{$bibnum}->{patrons_count} = $patrons_count; >+ $hold_info->{patrons_count} = $patrons_count->{$bibnum}; > >- my $pull_count = $items_count <= $patrons_count ? $items_count : $patrons_count; >+ my $pull_count = $items_count <= $patrons_count->{$bibnum} ? $items_count : $patrons_count->{$bibnum}; > if ( $pull_count == 0 ) { > delete($reserves->{$bibnum}); > next; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24488
:
97773
|
106379
|
106882
|
107206
|
107213
|
111341
|
111342
|
111343
|
111347
|
111348
|
111349
|
111350
|
111358
|
111359
|
111360
|
111361
|
111362
|
112815
|
112816
|
112817
|
112818
|
112819
|
113695
|
113696
|
113697
|
113698
|
113699
|
113700
|
113756
|
113757
|
113763
|
113764
|
113774
|
113775
|
113776
|
113777
|
113778
|
113798
|
113829
|
113830
|
113831
|
113832
|
113833
|
113834
|
113835
|
113836
|
113837
|
113838
|
113839
|
113840
|
113841
|
113842
|
113850
|
113851
|
113852
|
113853
|
113854
|
113855
|
113856
|
113857
|
113858
|
113859
|
113860
|
113861
|
113862
|
113863
|
113864
|
114835
|
114836
|
114837
|
114838
|
114839
|
114840
|
114841
|
114842
|
114843
|
114844
|
114845
|
114846
|
114847
|
114848
|
114849
|
114850
|
116362
|
116363
|
116364
|
116365
|
116366
|
116367
|
116368
|
116369
|
116370
|
116371
|
116372
|
116373
|
116374
|
116375
|
116376
|
116377
|
116384