From 183a918d1cf084e66a266ce415e224357b8a8b0c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 24 Nov 2020 12:19:32 +0100 Subject: [PATCH] Bug 27082: (bug 23013 follow-up) Remove pagination from uncertain prices When more than 20 orders with uncertain prices are displayed on the "uncertain prices" view, the pagination is displayed and will cause data loss if the form is submitted. The pagination is there since: commit 247dca306407ac9568344a0a37aca3bbcffc2468 Bug 23013: Upgrade DataTables in the staff client What's happening: When the form is submitted, all the orders with uncertain price are processed, but the posted values only contain the ones from the first page of the table. The orders that are not displayed on the first page will have their prices fields and uncertainprice set to NULL. Test plan: 1- create a basket 2- add more of 20 orders with uncertain price 3- click on uncertain price button 4- click on save button => There is no more pagination and the form behaves correctly --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt index 20f1fbe302..16c5a5db75 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt @@ -148,7 +148,7 @@ "aoColumnDefs": [ { "aTargets": [ -1, -2, -3 ], "bSortable": false, "bSearchable": false }, ], - "sPaginationType": "full" + "sPaginationType": "four_button" })); $(".check_uncertain").on("change",function(){ var form = document.getElementById("uncertainprices"); -- 2.20.1