From 845c93a69d6ef9b5c1eb3f560db40e8c06f10e54 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 1 Dec 2020 11:44:56 +0100 Subject: [PATCH] Bug 27117 : Only place_holds permission is needed to adjust pickup locations The GET /pickup_locations route is requesting the whole reserveforothers permission whereas only the subpermission place_holds is needed. Test plan: 0. Don't apply this patch 1. Set the subpermission place_holds but modify_holds_priority 2. Edit a hold and click the pickup library dropdown list 3. You get a JS alert and log displays GET /api/v1/app.pl/api/v1/holds/5/pickup_locations 403 Forbidden 4. Apply this patch 5. Reload the page, click the dropdown list, modify the pickup location and save => Success! --- api/v1/swagger/paths/holds.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json index 3792985c8c..386b4a9470 100644 --- a/api/v1/swagger/paths/holds.json +++ b/api/v1/swagger/paths/holds.json @@ -672,7 +672,7 @@ }, "x-koha-authorization": { "permissions": { - "reserveforothers": "1" + "reserveforothers": "place_holds" } } } -- 2.20.1