Bugzilla – Attachment 11417 Details for
Bug 7805
Exposing the new list permissions in opac and staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7805 Followup for perlcritic messages
SIGNED-OFF-Bug-7805-Followup-for-perlcritic-messag.patch (text/plain), 1.96 KB, created by
Owen Leonard
on 2012-08-07 13:21:05 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7805 Followup for perlcritic messages
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-08-07 13:21:05 UTC
Size:
1.96 KB
patch
obsolete
>From 183a619db87aba93d40ac7f41559ae885a9a8839 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 14 Jun 2012 12:40:08 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 7805 Followup for perlcritic messages >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Tested by going to Lists and doubleclicking a list to see >its contents (in opac or staff). It works. No warnings >in the log. I am ready to sign off. >--- > C4/VirtualShelves.pm | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index 20f3620..25d092a 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -221,7 +221,7 @@ Returns the above-mentioned fields for passed virtual shelf number. > > =cut > >-sub GetShelf ($) { >+sub GetShelf { > my ($shelfnumber) = @_; > my $query = qq( > SELECT shelfnumber, shelfname, owner, category, sortfield, >@@ -252,7 +252,7 @@ from C4::Circulation. > > =cut > >-sub GetShelfContents ($;$$$) { >+sub GetShelfContents { > my ($shelfnumber, $row_count, $offset, $sortfield) = @_; > my $dbh=C4::Context->dbh(); > my $sth1 = $dbh->prepare("SELECT count(*) FROM virtualshelfcontents WHERE shelfnumber = ?"); >@@ -351,7 +351,7 @@ sub AddToShelf { > my $sth = $dbh->prepare($query); > > $sth->execute( $shelfnumber, $biblionumber ); >- ($sth->rows) and return undef; # already on shelf >+ ($sth->rows) and return; # already on shelf > $query = qq( > INSERT INTO virtualshelfcontents > (shelfnumber, biblionumber, flags, borrowernumber) >@@ -658,15 +658,6 @@ sub _biblionumber_sth { #only used in obsolete sub below > $sth; > } > >-sub each_biblionumbers (&$) { #OBSOLETE >- my ($code,$shelf) = @_; >- my $ref = _biblionumber_sth($shelf)->fetchall_arrayref; >- map { >- $_=$$_[0]; >- $code->(); >- } @$ref; >-} >- > sub _CheckShelfName { > my ($name, $cat, $owner, $number)= @_; > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7805
:
8529
|
9387
|
9805
|
10274
|
11417
|
13288
|
13289