Bugzilla – Attachment 114297 Details for
Bug 27188
Show current class in plugins home
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27188: Show current class in plugins home
Bug-27188-Show-current-class-in-plugins-home.patch (text/plain), 5.03 KB, created by
Fridolin Somers
on 2020-12-10 09:56:21 UTC
(
hide
)
Description:
Bug 27188: Show current class in plugins home
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2020-12-10 09:56:21 UTC
Size:
5.03 KB
patch
obsolete
>From f6def32ea26a7fafd1693deeadb46c327af572d6 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 10 Dec 2020 10:50:03 +0100 >Subject: [PATCH] Bug 27188: Show current class in plugins home > >In plugins home, when searching on a specific class, you see the table but no reminder which class is displayed. >Only when there are no results you see it in message. >I propose to show it in H1 title and remove it from no results message. > >Sort of what is asked in Bug 16391. > >This change adds missing specific message to class 'ill_availability_services'. > >This change removed the message 'Unknown plugin type'. >Seems useless to me since you must change manually method in URL to get it. >And this may be usefull for unlisted classes like hooks 'opac_js', ... > >Test plan : >1) Enable plugins >2) Install a tool plugin like InLibro Carrousel >3) Go to Administration > Manage plugins >4) Check you see the plugin and title 'All plugins' >5) In menu select 'View tool plugins' >6) Check you see the plugin and title 'Plugins that can be used as a tool' >7) In menu select 'View report plugins' >6) Check you see message 'No plugins installed' and title 'Plugins that can create a report' >7) Edit URL and go to > /cgi-bin/koha/plugins/plugins-home.pl?method=opac_js >8) Check you see message 'No plugins installed' and title 'Plugins with class opac_js' >--- > .../prog/en/modules/plugins/plugins-home.tt | 40 ++++++++++--------- > 1 file changed, 22 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >index 700c8d167b..74d53233fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >@@ -57,7 +57,27 @@ > [% END %] > </div> > [% END %] >- <h1>Plugins</h1> >+ <h1> >+ [% UNLESS ( method ) %] >+ <span>All plugins<span> >+ [% ELSE %] >+ [% IF method == 'tool' %] >+ <span>Plugins that can be used as a tool</span> >+ [% ELSIF method == 'report' %] >+ <span>Plugins that can create a report</span> >+ [% ELSIF method == 'to_marc' %] >+ <span>Plugins that can convert files to MARC records</span> >+ [% ELSIF method == 'opac_online_payment' %] >+ <span>Plugins that can process online payments via the public catalog</span> >+ [% ELSIF method == 'intranet_catalog_biblio_enhancements' %] >+ <span>Plugins that can enhance the intranet catalog biblio records</span> >+ [% ELSIF method == 'ill_availability_services' %] >+ <span>Plugins that can provide ILL availability</span> >+ [% ELSE %] >+ <span>Plugins with class <em>[% method | html %]</em></span> >+ [% END %] >+ [% END %] >+ </h1> > > [% IF search_results %] > <h2>Search results</h2> >@@ -83,23 +103,7 @@ > [% END %] > > [% UNLESS ( plugins ) %] >- [% UNLESS ( method ) %] >- <div class="dialog message">No plugins installed</div> >- [% ELSE %] >- [% IF method == 'tool' %] >- <div class="dialog message">No plugins that can be used as a tool are installed</div> >- [% ELSIF method == 'report' %] >- <div class="dialog message">No plugins that can create a report are installed</div> >- [% ELSIF method == 'to_marc' %] >- <div class="dialog message">No plugins that can convert files to MARC records are installed</div> >- [% ELSIF method == 'opac_online_payment' %] >- <div class="dialog message">No plugins that can process online payments via the public catalog are installed</div> >- [% ELSIF method == 'intranet_catalog_biblio_enhancements' %] >- <div class="dialog message">No plugins that can enhance the intranet catalog biblio records are installed</div> >- [% ELSE %] >- <div class="dialog message">Unknown plugin type <em>[% method | html %]</em></div> >- [% END %] >- [% END %] >+ <div class="dialog message">No plugins installed</div> > [% ELSE %] > <table id="installed_plugins"> > <tr> >-- >2.29.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27188
: 114297