From 3ff4189b00ddf6ca210ab4c7a31996ac06e8039b Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 28 Oct 2020 19:00:28 +0000 Subject: [PATCH] Bug 26851: Don't generate a notice to library if no content To test: 1 - Check out an over due to a patron 2 - Set overdue triggers to a trigger less than number of days overdue 3 - Make sure the patron has no email 4 - Set content of ODUE notice to: [%# Comment will not print %] 5 - perl misc/cronjobs/overdue_notices.pl 6 - Check the message queue 7 - There is a notice sent to the library: "These messages were not sent directly to the patrons." With no messages 8 - Apply patch 9 - Repeat 10 - No new message generated Signed-off-by: Victor Grousset/tuxayo --- misc/cronjobs/overdue_notices.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 591feea145..70c444ee70 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -705,7 +705,7 @@ END_SQL message_transport_type => $letter_exists ? $effective_mtt : $mtt, } ); - unless ($letter) { + unless ($letter && $letter->{content}) { $verbose and warn qq|Message '$overdue_rules->{"letter$i"}' content not found|; # this transport doesn't have a configured notice, so try another next; -- 2.29.2