From 8a8cd234231ef6c3718f538675f542f5a4f28aef Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Wed, 30 Dec 2020 14:33:44 +0100 Subject: [PATCH] Bug 27316: In Elasticsearch mappings use yes/no for sortable In search engine configuration (Elasticsearch), there is a colum 'sortable'. It contains 'Undef', 0 or 1. 0 and 1 are not really friendly values for a boolean. And also the translation seems to replace 0 by empty string (seen in fr-FR translation). I propose to replace by Yes/No like other boolean. Test plan : 1) Without patch, look at Administration > Search engine configuration (Elasticsearch) 2) Look at tab 'Bibliographic records' 3) Look at a row containing 0 and a row containing 1 4) Apply patch 5) Refresh page 6) Check 0 is now 'No' and 1 is now 'Yes' 7) Check creating a new row with 'Yes' or 'No' Signed-off-by: Lucas Gass --- .../en/modules/admin/searchengine/elasticsearch/mappings.tt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt index bd726dacca..580a069d5a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ -336,14 +336,14 @@ a.add, a.delete { [% END %] [% IF mapping.sort == 0 %] - + [% ELSE %] - + [% END %] [% IF mapping.sort == 1 %] - + [% ELSE %] - + [% END %] @@ -410,8 +410,8 @@ a.add, a.delete { -- 2.11.0