From c38c1ff1f064fc72d949461fda67bd02165236f1 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Thu, 11 Feb 2021 15:33:35 +0100 Subject: [PATCH] Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. Test plan : 1) Dont apply patch 2) Build an item and a linked analytical record with 773$0 and $9 3) Enable EasyAnalyticalRecords 4) Try to delete the item 5) You have an alert because linked to analytics 6) Disable EasyAnalyticalRecords 7) Try to delete the item 8) You have an alert because linked to analytics 9) Apply patch 10) Try to delete the item 11) No alert, it works :D --- C4/Items.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/C4/Items.pm b/C4/Items.pm index 48aed7b195..691dca0b67 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -1304,6 +1304,10 @@ counts Usage of itemnumber in Analytical bibliorecords. sub GetAnalyticsCount { my ($itemnumber) = @_; + if ( !C4::Context->preference('EasyAnalyticalRecords') ) { + return 0; + } + ### ZOOM search here my $query; $query= "hi=".$itemnumber; -- 2.30.0