Bugzilla – Attachment 117600 Details for
Bug 24446
Stockrotation: Update to use daterequested in branchtransfers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24446: (QA follow-up) Update unit test for ModItemTransfer
Bug-24446-QA-follow-up-Update-unit-test-for-ModIte.patch (text/plain), 2.17 KB, created by
Jonathan Druart
on 2021-03-03 14:32:25 UTC
(
hide
)
Description:
Bug 24446: (QA follow-up) Update unit test for ModItemTransfer
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-03-03 14:32:25 UTC
Size:
2.17 KB
patch
obsolete
>From d670459cd91f69fbaf9883a5b20f5e0fe9cd10f8 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 22 Feb 2021 12:50:55 +0000 >Subject: [PATCH] Bug 24446: (QA follow-up) Update unit test for > ModItemTransfer > >Update unit test to reflect we now use cancellationdate and >cancellation_reason in ModItemTransfer >--- > t/db_dependent/Items.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index a5e4a52919..a6a45bf925 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -146,7 +146,7 @@ subtest 'ModItemTransfer tests' => sub { > ); > > ModItemTransfer( $item->itemnumber, $library1->{branchcode}, >- $library2->{branchcode} ); >+ $library2->{branchcode}, 'Manual' ); > > my $transfers = Koha::Item::Transfers->search( > { >@@ -159,7 +159,7 @@ subtest 'ModItemTransfer tests' => sub { > is($item->holdingbranch, $library1->{branchcode}, "Items holding branch was updated to frombranch"); > > ModItemTransfer( $item->itemnumber, $library2->{branchcode}, >- $library1->{branchcode} ); >+ $library1->{branchcode}, 'Manual' ); > $transfers = Koha::Item::Transfers->search( > { itemnumber => $item->itemnumber, }, > { order_by => { '-asc' => 'branchtransfer_id' } } >@@ -168,8 +168,8 @@ subtest 'ModItemTransfer tests' => sub { > is($transfers->count, 2, "Second transfer recorded on second call of ModItemTransfer"); > my $transfer1 = $transfers->next; > my $transfer2 = $transfers->next; >- isnt($transfer1->datearrived, undef, "First transfer marked as completed by ModItemTransfer"); >- like($transfer1->comments,qr/^Canceled/, "First transfer contains 'Canceled' comment"); >+ isnt($transfer1->datecancelled, undef, "First transfer marked as cancelled by ModItemTransfer"); >+ like($transfer1->cancellation_reason,qr/^Manual/, "First transfer contains cancellation_reason 'Manual'"); > is($transfer2->datearrived, undef, "Second transfer is now the active transfer"); > $item->discard_changes; > is($item->holdingbranch, $library2->{branchcode}, "Items holding branch was updated to frombranch"); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24446
:
105943
|
105944
|
105945
|
107246
|
107247
|
107248
|
107249
|
107250
|
107252
|
107253
|
107254
|
107255
|
107256
|
107301
|
107302
|
107303
|
107304
|
107305
|
110280
|
110281
|
110282
|
110283
|
110533
|
110534
|
110535
|
110536
|
110537
|
110538
|
110539
|
110540
|
110541
|
110542
|
111322
|
116557
|
116558
|
116559
|
116560
|
116561
|
116562
|
116563
|
116564
|
116565
|
116566
|
116567
|
116568
|
116569
|
116570
|
117589
|
117590
|
117591
|
117592
|
117593
|
117594
|
117595
|
117596
|
117597
|
117598
|
117599
| 117600 |
117601
|
117602
|
117603
|
117604
|
117605
|
117606
|
117607
|
120116