Bugzilla – Attachment 11768 Details for
Bug 8240
There is dead code in orderreceive.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8240: Followup: the receive param is never used and can be deleted
Bug-8240-Followup-the-receive-param-is-never-used-.patch (text/plain), 1.86 KB, created by
Jonathan Druart
on 2012-08-23 09:03:49 UTC
(
hide
)
Description:
Bug 8240: Followup: the receive param is never used and can be deleted
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-08-23 09:03:49 UTC
Size:
1.86 KB
patch
obsolete
>From d460020e5b535ee2c349ed886724388e9431b0fa Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 23 Aug 2012 11:03:34 +0200 >Subject: [PATCH] Bug 8240: Followup: the receive param is never used and can > be deleted > >To search an order for receiving, the new page parcel.pl is more >adapted. >--- > acqui/orderreceive.pl | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl >index 9d9a4870..1271b5c 100755 >--- a/acqui/orderreceive.pl >+++ b/acqui/orderreceive.pl >@@ -38,8 +38,6 @@ It permit to write a new order as 'received'. > > to know on what supplier this script has to display receive order. > >-=item receive >- > =item invoice > > the number of this invoice. >@@ -84,7 +82,6 @@ my $input = new CGI; > my $dbh = C4::Context->dbh; > my $booksellerid = $input->param('booksellerid'); > my $ordernumber = $input->param('ordernumber'); >-my $search = $input->param('receive'); > my $invoice = $input->param('invoice'); > my $freight = $input->param('freight'); > my $datereceived = $input->param('datereceived'); >@@ -95,7 +92,8 @@ $datereceived = $datereceived ? C4::Dates->new($datereceived, 'iso') : C4::Dates > my $bookseller = GetBookSellerFromId($booksellerid); > my $input_gst = ($input->param('gst') eq '' ? undef : $input->param('gst')); > my $gst= $input_gst // $bookseller->{gstrate} // C4::Context->preference("gist") // 0; >-my $results = SearchOrder($ordernumber,$search); >+my $results; >+$results = SearchOrder($ordernumber) if $ordernumber; > > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { >@@ -108,7 +106,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > >-unless ( @$results ) { >+unless ( $results and @$results) { > output_html_with_http_headers $input, $cookie, $template->output; > exit; > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8240
:
10244
|
10329
|
10479
|
11768
|
12816
|
12943
|
13904