From a911ea7cbb8a6acd9e7b96e85a611e126dfc74d8 Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Tue, 31 Mar 2020 12:19:28 +0300 Subject: [PATCH 3/4] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy --- circ/renew.pl | 2 +- .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/circ/renew.pl b/circ/renew.pl index 3ea9a02113..1d093ba69c 100755 --- a/circ/renew.pl +++ b/circ/renew.pl @@ -69,7 +69,7 @@ if ($barcode) { $borrower = $issue->borrower(); my $patron = Koha::Patrons->find($borrower->borrowernumber); $balance = $patron->account->balance; - my $amountlimit = C4::Context->preference("noissuescharge"); + my $amountlimit = C4::Context->preference("OPACFineNoRenewals"); if ( ( $borrower->debarred() || q{} ) lt dt_from_string()->ymd() ) { my $can_renew; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index 67ef50a828..a451bd06bc 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -597,7 +597,8 @@ OPAC: - Only allow patrons to renew their own books on the OPAC if they have less than - pref: OPACFineNoRenewals class: currency - - '[% local_currency %] in fines (leave blank to disable).' + - '[% local_currency %] in fines (leave blank to disable). + -
NOTE: If set, confirmation dialog is shown when renewing for patron with fines from staff interface.' - - pref: OPACFineNoRenewalsIncludeCredits choices: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index 4f8fef8f8b..21214253e2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -1129,7 +1129,7 @@ [% UNLESS ( patron.borrowernumber ) %][% UNLESS ( borrowers ) %]window.onload=function(){ $('#findborrower').focus(); };[% END %][% END %] - var amountlimit = "[% Koha.Preference('noissuescharge') | html %]"; + var amountlimit = "[% Koha.Preference('OPACFineNoRenewals') | html %]"; var fines = "[% fines | html %]"; var MSG_CONFRIM_RENEW = _("The patron has a debt of %s.\n Are you sure you want to renew checkout(s)?").format(fines); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt index 0bf918e951..79c7ff1f41 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ -946,7 +946,7 @@ columns_settings_issues_table = [% TablesSettings.GetColumns( 'members', 'moremember', 'issues-table', 'json' ) | $raw %] - var amountlimit = "[% Koha.Preference('noissuescharge') | html %]"; + var amountlimit = "[% Koha.Preference('OPACFineNoRenewals') | html %]"; var fines = "[% fines | html %]"; var MSG_CONFRIM_RENEW = _("The patron has a debt of %s.\n Are you sure you want to renew checkout(s)?").format(fines); -- 2.25.1