From ef279d4373bb1de6c16c95e818a87cfef1567747 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 23 Apr 2021 15:22:44 +0000 Subject: [PATCH] Bug 24446: (follow-up) Fix tests The tests were failing because we weren't actually changing the item, so store was doing nothing. We need to transfer 'from' a new branch so that the holdingbranch is changed --- t/db_dependent/Koha/SearchEngine/Indexer.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t index 3d8454c234..882b5b10f9 100755 --- a/t/db_dependent/Koha/SearchEngine/Indexer.t +++ b/t/db_dependent/Koha/SearchEngine/Indexer.t @@ -198,10 +198,10 @@ subtest 'Test indexer calls' => sub { } undef, "index_records is not called for $engine when calling ModDateLastSeen if skip_record_index"; warnings_are{ - ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual'); + ModItemTransfer( $item->itemnumber, $item2->homebranch, $item->homebranch,'Manual'); } [$engine,"Koha::Item"], "index_records is called for $engine when calling ModItemTransfer"; warnings_are{ - ModItemTransfer( $item->itemnumber, $item2->homebranch, $item->homebranch,'Manual',{skip_record_index=>1}); + ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual',{skip_record_index=>1}); } undef, "index_records is not called for $engine when calling ModItemTransfer with skip_record_index"; warnings_are{ -- 2.11.0