From 18181a41298e7136306825a778821a7f0695a35d Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 29 Apr 2021 15:37:49 -0300 Subject: [PATCH] Bug 28248: aqorders.created_by is nullable This patch introduces a change to the spec to acknowledge that the field is nullable. This is fixed in 21.05+ as part of bug 20212. To test: 1. Have an order with created_by = NULL 2. Use your favourite REST tool (Advanced REST Client(libre), Postman?) to fetch the order => FAIL: It throws a nasty error about non-nullable field being null 3. Apply this patch 4. Reload all 5. Repeat 2 => SUCCESS: It returns things, created_by is NULL, as it should 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall --- api/v1/swagger/definitions/order.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api/v1/swagger/definitions/order.json b/api/v1/swagger/definitions/order.json index f3d07d3735..bbc1b24e33 100644 --- a/api/v1/swagger/definitions/order.json +++ b/api/v1/swagger/definitions/order.json @@ -13,7 +13,10 @@ "description": "Identifier for the linked bibliographic record" }, "created_by": { - "type": "integer", + "type": [ + "integer", + "null" + ], "description": "Interal patron identifier of the order line creator" }, "entry_date": { -- 2.24.3 (Apple Git-128)