Bugzilla – Attachment 121094 Details for
Bug 28367
Wrong plack condition in C4/Auth_with_shibboleth.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm
Bug-28367-Fix-plack-condition-in-C4Authwithshibbol.patch (text/plain), 1.53 KB, created by
Jonathan Druart
on 2021-05-18 08:43:48 UTC
(
hide
)
Description:
Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-05-18 08:43:48 UTC
Size:
1.53 KB
patch
obsolete
>From 467af991ea33cf24be191759cecd184dbd8fd52e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 May 2021 10:43:05 +0200 >Subject: [PATCH] Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm > >C4/Auth_with_shibboleth.pm has: > if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) >When others have: > if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) > >This has been highlighted by https://gitlab.com/koha-community/koha-testing-docker/-/issues/249 that introduces a PLACK_WORKERS env vars, and t/Auth_with_shibboleth.t was failing with > > # Failed test 'checkpw_shib tests' > # at t/Auth_with_shibboleth.t line 335. > Invalid parameter passed, categorycode= does not exist# Looks like your test exited with 255 just after 5. >--- > C4/Auth_with_shibboleth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index 1e89020c024..2b59f86c053 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -150,7 +150,7 @@ sub _sync { > my %borrower; > $borrower{'borrowernumber'} = $borrowernumber; > while ( my ( $key, $entry ) = each %{$config->{'mapping'}} ) { >- if ( any { /(^psgi|^plack)/i } keys %ENV ) { >+ if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) { > $borrower{$key} = ( $entry->{'is'} && $ENV{"HTTP_" . uc($entry->{'is'}) } ) || $entry->{'content'} || ''; > } else { > $borrower{$key} = ( $entry->{'is'} && $ENV{ $entry->{'is'} } ) || $entry->{'content'} || ''; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28367
: 121094 |
121099