Bugzilla – Attachment 121612 Details for
Bug 11999
Add two checks in CanBookBeReserved and CanItemBeReserved
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
Test fails for holds - 2021-06-04
11999 - Test fails for holds - 2021-06-04.txt (text/plain), 16.51 KB, created by
David Nind
on 2021-06-03 22:42:35 UTC
(
hide
)
Description:
Test fails for holds - 2021-06-04
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-06-03 22:42:35 UTC
Size:
16.51 KB
patch
obsolete
>root@kohadevbox:koha(bz11999)$ prove -v t/db_dependent/Holds.t >t/db_dependent/Holds.t .. >1..71 >ok 1 - Test GetReserves() >ok 2 - Reserve 1 has a priority of 1 >ok 3 - Reserve 2 has a priority of 2 >ok 4 - Reserve 3 has a priority of 3 >ok 5 - Reserve 4 has a priority of 4 >ok 6 - Reserve 5 has a priority of 5 >ok 7 - holds_placed_today should return a valid reserve date >ok 8 - holds_placed_today should return a valid borrowernumber >ok 9 - holds_placed_today should return a valid branchcode >ok 10 - Test holds_placed_today() >ok 11 - Koha::Holds found the hold >ok 12 - Got biblio using biblio() method >ok 13 - biblio method returns stashed biblio >ok 14 - Got item using item() method >ok 15 - item method returns stashed item >ok 16 - Got branch using branch() method >ok 17 - branch method returns stashed branch >ok 18 - Koha::Holds->waiting returns waiting holds >ok 19 - Koha::Holds->unfilled returns unfilled holds >ok 20 - Test Koha::Patron->holds >ok 21 - Test ModReserve, priority changed correctly >ok 22 - Test ModReserve, suspend hold >ok 23 - Test ModReserve, suspend until date >ok 24 - Test ModReserve, priority changed correctly >ok 25 - Test ToggleSuspend(), no date >ok 26 - Test ToggleSuspend(), with date >ok 27 - Test AutoUnsuspendReserves() >ok 28 - Test SuspendAll() >ok 29 - Test SuspendAll(), with date >ok 30 - Test resuming with SuspendAll() >ok 31 - Test resuming with SuspendAll(), should have no suspend until date >ok 32 - Test ModReserveMinusPriority() >ok 33 - Test AlterPriority(), move to top >ok 34 - Test AlterPriority(), move down >ok 35 - Test AlterPriority(), move up >ok 36 - Test AlterPriority(), move to bottom >not ok 37 - $branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394) ># Failed test '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)' ># at t/db_dependent/Holds.t line 268. ># got: 'tooManyReserves' ># expected: 'OK' >not ok 38 - $branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394) ># Failed test '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)' ># at t/db_dependent/Holds.t line 276. >not ok 39 - ... unless canreservefromotherbranches is ON (bug 2394) ># Failed test '... unless canreservefromotherbranches is ON (bug 2394)' ># at t/db_dependent/Holds.t line 283. >ok 40 - The 3rd hold should have a priority set to 3 >ok 41 - After ModReserve, the 3rd reserve becomes the first on the waiting list >not ok 42 - Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled ># Failed test 'Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled' ># at t/db_dependent/Holds.t line 330. ># got: 'tooManyReserves' ># expected: 'OK' >ok 43 - Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled >ok 44 - Patron cannot place a second item level hold for a given item >ok 45 - Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled >ok 46 - Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled >not ok 47 - Patron can place hold on item that is not for loan but holdable ( notforloan < 0 ) ># Failed test 'Patron can place hold on item that is not for loan but holdable ( notforloan < 0 )' ># at t/db_dependent/Holds.t line 353. ># got: 'tooManyReserves' ># expected: 'OK' >ok 48 - Hold cannot be trapped for item that is not for loan but holdable ( notforloan < 0 ) >ok 49 - Hold is trapped for item that is not for loan but holdable ( notforloan < 0 ) >ok 50 - Hold cannot be trapped for item with notforloan value matching SkipHoldTrapOnNotForLoanValue >ok 51 - Hold cannot be trapped for item with notforloan value matching SkipHoldTrapOnNotForLoanValue >ok 52 - cannot request item that you have already reservedd >not ok 53 - can request item if we are not checking holds counts, but only if policy allows or forbids it ># Failed test 'can request item if we are not checking holds counts, but only if policy allows or forbids it' ># at t/db_dependent/Holds.t line 377. ># got: 'tooManyReserves' ># expected: 'OK' >not ok 54 - cannot request item if policy that matches on item-level item type forbids it ># Failed test 'cannot request item if policy that matches on item-level item type forbids it' ># at t/db_dependent/Holds.t line 394. ># got: 'tooManyReserves' ># expected: 'noReservesAllowed' >not ok 55 - cannot request item if policy that matches on item-level item type forbids it even if ignoring counts ># Failed test 'cannot request item if policy that matches on item-level item type forbids it even if ignoring counts' ># at t/db_dependent/Holds.t line 398. ># got: 'tooManyReserves' ># expected: 'noReservesAllowed' ># Subtest: CanItemBeReserved > 1..2 > # Subtest: noReservesAllowed > 1..5 > ok 1 - With item level set, rule from item must be picked (CANNOT) > ok 2 - With item level set, rule from item must be picked (CAN) > ok 3 - With biblio level set, rule from biblio must be picked (CANNOT) > ok 4 - With biblio level set, rule from biblio must be picked (CAN) > ok 5 - When no holds allowed and no holds per record allowed should return noReservesAllowed > ok 1 - noReservesAllowed > # Subtest: tooManyHoldsForThisRecord + tooManyReserves + itemAlreadyOnHold > 1..7 > not ok 1 - A biblio-level hold already exists - another hold can be placed on a specific item item > # Failed test 'A biblio-level hold already exists - another hold can be placed on a specific item item' > # at t/db_dependent/Holds.t line 525. > # got: 'tooManyReserves' > # expected: 'OK' > not ok 2 - A biblio-level hold already exists - another hold can be placed on a specific item item > # Failed test 'A biblio-level hold already exists - another hold can be placed on a specific item item' > # at t/db_dependent/Holds.t line 525. > # got: 'tooManyReserves' > # expected: 'OK' > not ok 3 - A item-level hold already exists and holds_per_record=1, another hold cannot be placed on this record > # Failed test 'A item-level hold already exists and holds_per_record=1, another hold cannot be placed on this record' > # at t/db_dependent/Holds.t line 552. > # got: 'tooManyReserves' > # expected: 'tooManyHoldsForThisRecord' > not ok 4 - A item-level hold already exists and holds_per_record=1 - tooManyHoldsForThisRecord has priority over tooManyReserves > # Failed test 'A item-level hold already exists and holds_per_record=1 - tooManyHoldsForThisRecord has priority over tooManyReserves' > # at t/db_dependent/Holds.t line 567. > # got: 'tooManyReserves' > # expected: 'tooManyHoldsForThisRecord' > not ok 5 - A item-level hold already exists but holds_per_record=2- another item-level hold can be placed on this record > # Failed test 'A item-level hold already exists but holds_per_record=2- another item-level hold can be placed on this record' > # at t/db_dependent/Holds.t line 582. > # got: 'tooManyReserves' > # expected: 'OK' > ok 6 - A item-level holds already exists on this item, itemAlreadyOnHold should be raised > ok 7 - This patron has already placed reservesallowed holds, tooManyReserves should be raised > # Looks like you failed 5 tests of 7. > not ok 2 - tooManyHoldsForThisRecord + tooManyReserves + itemAlreadyOnHold > # Failed test 'tooManyHoldsForThisRecord + tooManyReserves + itemAlreadyOnHold' > # at t/db_dependent/Holds.t line 611. > # Looks like you failed 1 test of 2. >not ok 56 - CanItemBeReserved ># Failed test 'CanItemBeReserved' ># at t/db_dependent/Holds.t line 612. >not ok 57 - CanItemBeReserved should return 'notReservable' ># Failed test 'CanItemBeReserved should return 'notReservable'' ># at t/db_dependent/Holds.t line 651. ># got: 'tooManyReserves' ># expected: 'notReservable' >not ok 58 - CanItemBeReserved should use PatronLibrary rule when ReservesControlBranch set to 'PatronLibrary' ># Failed test 'CanItemBeReserved should use PatronLibrary rule when ReservesControlBranch set to 'PatronLibrary'' ># at t/db_dependent/Holds.t line 657. ># got: 'tooManyReserves' ># expected: 'cannotReserveFromOtherBranches' >not ok 59 - CanItemBeReserved should use item home library rule when ReservesControlBranch set to 'ItemsHomeLibrary' ># Failed test 'CanItemBeReserved should use item home library rule when ReservesControlBranch set to 'ItemsHomeLibrary'' ># at t/db_dependent/Holds.t line 661. ># got: 'tooManyReserves' ># expected: 'OK' >not ok 60 - CanItemBeReserved should return 'OK' ># Failed test 'CanItemBeReserved should return 'OK'' ># at t/db_dependent/Holds.t line 665. ># got: 'tooManyReserves' ># expected: 'OK' >ok 61 - Patron can reserve item with hold limit of 1, no holds placed >ok 62 - Patron cannot reserve item with hold limit of 1, 1 bib level hold placed >not ok 63 - Patron can reserve item if checking policy but not counts ># Failed test 'Patron can reserve item if checking policy but not counts' ># at t/db_dependent/Holds.t line 706. ># got: 'tooManyReserves' ># expected: 'OK' >ok 64 - Patron cannot reserve item with hold limit of 1, 1 bib level hold placed ># Subtest: Test max_holds per library/patron category > 1..6 > ok 1 - Patron now has 3 holds > not ok 2 - Patron can place hold with no borrower circ rules > # Failed test 'Patron can place hold with no borrower circ rules' > # at t/db_dependent/Holds.t line 750. > # got: 'tooManyReserves' > # expected: 'OK' > not ok 3 - Patron can place hold with branch/category rule of 5, category rule of 3 > # Failed test 'Patron can place hold with branch/category rule of 5, category rule of 3' > # at t/db_dependent/Holds.t line 771. > # got: 'tooManyReserves' > # expected: 'OK' > ok 4 - Patron cannot place hold with only a category rule of 3 > ok 5 - Patron cannot place hold with only a branch/category rule of 3 > not ok 6 - Patron can place hold with branch/category rule of 5, category rule of 5 > # Failed test 'Patron can place hold with branch/category rule of 5, category rule of 5' > # at t/db_dependent/Holds.t line 791. > # got: 'tooManyReserves' > # expected: 'OK' > # Looks like you failed 3 tests of 6. >not ok 65 - Test max_holds per library/patron category ># Failed test 'Test max_holds per library/patron category' ># at t/db_dependent/Holds.t line 792. ># Subtest: Pickup location availability tests > 1..4 > ok 1 - Library is a pickup location > ok 2 - Item cannot be transferred > ok 3 - Library is not a pickup location > ok 4 - Cannot set unknown library as pickup location >ok 66 - Pickup location availability tests ># Subtest: CanItemBeReserved / holds_per_day tests > 1..10 > ok 1 - Patron can reserve item with hold limit of 1, no holds placed > ok 2 - Patron cannot reserve item with hold limit of 1, 1 bib level hold placed > not ok 3 - Patron can reserve item with 2 reserves daily cap > # Failed test 'Patron can reserve item with 2 reserves daily cap' > # at t/db_dependent/Holds.t line 907. > # Structures begin differing at: > # $got->{limit} = '1' > # $expected->{limit} = Does not exist > not ok 4 - Patron cannot a third item with 2 reserves daily cap > # Failed test 'Patron cannot a third item with 2 reserves daily cap' > # at t/db_dependent/Holds.t line 922. > # Structures begin differing at: > # $got->{status} = 'tooManyReserves' > # $expected->{status} = 'tooManyReservesToday' > not ok 5 - Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap > # Failed test 'Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap' > # at t/db_dependent/Holds.t line 933. > # Structures begin differing at: > # $got->{limit} = '1' > # $expected->{limit} = Does not exist > ok 6 - Patron cannot reserve if holds_per_day is 0 (i.e. 0 is 0) > ok 7 - Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap) > not ok 8 - Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap) > # Failed test 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)' > # at t/db_dependent/Holds.t line 994. > # Structures begin differing at: > # $got->{status} = 'tooManyReserves' > # $expected->{status} = 'OK' > not ok 9 - Unlimited daily holds, but reached reservesallowed > # Failed test 'Unlimited daily holds, but reached reservesallowed' > # at t/db_dependent/Holds.t line 1007. > # Structures begin differing at: > # $got->{limit} = '1' > # $expected->{limit} = '3' > not ok 10 - Unlimited daily holds, but reached reservesallowed > # Failed test 'Unlimited daily holds, but reached reservesallowed' > # at t/db_dependent/Holds.t line 1014. > # Structures begin differing at: > # $got->{limit} = '1' > # $expected->{limit} = '3' > # Looks like you failed 6 tests of 10. >not ok 67 - CanItemBeReserved / holds_per_day tests ># Failed test 'CanItemBeReserved / holds_per_day tests' ># at t/db_dependent/Holds.t line 1021. ># Subtest: CanItemBeReserved / branch_not_in_hold_group > 1..9 > ok 1 - Patron can place hold if no circ_rules where defined > ok 2 - Patron can place hold because patron's home library is part of hold group > ok 3 - Patron cannot place hold because patron's home library is not part of hold group > ok 4 - Patron can place hold if holdallowed is set to "any" for library 2 > ok 5 - Patron cannot place hold if holdallowed is set to "hold group" for library 2 > ok 6 - Patron can place hold if holdallowed is set to "any" for itemtype 2 > ok 7 - Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2 > ok 8 - Patron can place hold if holdallowed is set to "any" for itemtype 2 and library 2 > ok 9 - Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2 and library 2 >ok 68 - CanItemBeReserved / branch_not_in_hold_group ># Subtest: CanItemBeReserved / pickup_not_in_hold_group > 1..9 > ok 1 - Patron can place hold if no circ_rules where defined > ok 2 - Patron can place hold because pickup location is part of hold group > ok 3 - Patron cannot place hold because pickup location is not part of hold group > ok 4 - Patron can place hold if default_branch_circ_rules is set to "any" for library 2 > ok 5 - Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for library 2 > ok 6 - Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2 > ok 7 - Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2 > ok 8 - Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2 and library 2 > ok 9 - Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2 >ok 69 - CanItemBeReserved / pickup_not_in_hold_group ># Subtest: non priority holds > 1..6 > ok 1 - Cannot renew > ok 2 - Item is on hold > ok 3 - Can renew > ok 4 - Item is on non priority hold > ok 5 - Cannot renew > ok 6 - Item is on hold >ok 70 - non priority holds ># Subtest: CanItemBeReserved rule precedence tests > 1..3 > ok 1 - Patron of specified category can place 1 hold on specified itemtype > ok 2 - Patron of specified category can place 1 hold on specified itemtype, cannot place a second > not ok 3 - Patron of specified category can place 1 hold on specified itemtype if library rule for all types and categories set to 2 > # Failed test 'Patron of specified category can place 1 hold on specified itemtype if library rule for all types and categories set to 2' > # at t/db_dependent/Holds.t line 1604. > # Structures begin differing at: > # $got->{limit} = '1' > # $expected->{limit} = Does not exist > # Looks like you failed 1 test of 3. >not ok 71 - CanItemBeReserved rule precedence tests ># Failed test 'CanItemBeReserved rule precedence tests' ># at t/db_dependent/Holds.t line 1612. ># Looks like you failed 17 tests of 71. >Dubious, test returned 17 (wstat 4352, 0x1100) >Failed 17/71 subtests > >Test Summary Report >------------------- >t/db_dependent/Holds.t (Wstat: 4352 Tests: 71 Failed: 17) > Failed tests: 37-39, 42, 47, 53-60, 63, 65, 67, 71 > Non-zero exit status: 17 >Files=1, Tests=71, 8 wallclock secs ( 0.06 usr 0.00 sys + 6.95 cusr 0.58 csys = 7.59 CPU) >Result: FAIL
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 11999
:
26589
|
28986
|
31524
|
35697
|
36358
|
36404
|
36630
|
38397
|
41951
|
41952
|
44631
|
44632
|
46262
|
46263
|
50224
|
50225
|
58741
|
58742
|
58743
|
63593
|
63594
|
63595
|
66267
|
66268
|
66269
|
66270
|
88300
|
88301
|
88302
|
88303
|
90142
|
90143
|
90144
|
90146
|
90147
|
91046
|
91402
|
91403
|
91479
|
91481
|
91494
|
91580
|
91581
|
91582
|
91590
|
91591
|
91592
|
91593
|
99927
|
99928
|
106481
|
106494
|
111687
|
111688
|
111689
|
112871
|
112872
|
112873
|
112874
|
120776
|
120777
|
120778
|
120779
|
120780
|
121531
| 121612